Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2114681: Add verification on kernel param rcutree.kthread #463

Closed
wants to merge 1 commit into from
Closed

Bug 2114681: Add verification on kernel param rcutree.kthread #463

wants to merge 1 commit into from

Conversation

shaior
Copy link
Contributor

@shaior shaior commented Sep 11, 2022

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2022

@shaior: This pull request references Bugzilla bug 2114681, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is CLOSED (ERRATA) instead
  • expected dependent Bugzilla bug 2102450 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2114681: Add verification on kernel param rcutree.kthread

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shaior
Once this PR has been reviewed and has the lgtm label, please assign kpouget for approval by writing /assign @kpouget in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2022

Hi @shaior. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yanirq
yanirq reviewed Sep 11, 2022
View reviewed changes
test/e2e/performanceprofile/functests/1_performance/rt-kernel.go
@@ -71,4 +76,25 @@ var _ = Describe("[performance]RT Kernel", func() {
err = nodes.HasPreemptRTKernel(&nonPerformancesWorkers[0])
Expect(err).To(HaveOccurred(), "Node should have non-RT kernel")
})

It("[test_id:rctree] Should have kernel param rcutree.kthread", func() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test id should be replaced eventually

@yanirq
Copy link
Contributor

yanirq commented Sep 11, 2022

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2022

@shaior: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws cf26f1f link true /test e2e-aws
ci/prow/e2e-gcp-pao cf26f1f link true /test e2e-gcp-pao

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

marioferh
marioferh reviewed Sep 12, 2022
View reviewed changes
test/e2e/performanceprofile/functests/1_performance/rt-kernel.go
@@ -71,4 +76,25 @@ var _ = Describe("[performance]RT Kernel", func() {
err = nodes.HasPreemptRTKernel(&nonPerformancesWorkers[0])
Expect(err).To(HaveOccurred(), "Node should have non-RT kernel")
})

It("[test_id:rctree] Should have kernel param rcutree.kthread", func() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we have another test to check kernel boot args:

cluster-node-tuning-operator/test/e2e/pao/functests/1_performance/performance.go

Line 122 in a7fcf60

It("[test_id:31198] Should set CPU affinity kernel argument", func() {

It is necessary to do it in a new file? Could it be added there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes np, will do in the PR targeting master branch.

@shaior shaior closed this Sep 12, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 12, 2022

@shaior: An error was encountered removing this pull request from the external tracker bugs for bug 2114681 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. response code 400 not 200

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 2114681: Add verification on kernel param rcutree.kthread

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shaior
Copy link
Contributor Author

shaior commented Sep 12, 2022

new PR targeting master branch:
#464

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanirq yanirq yanirq left review comments

@marioferh marioferh marioferh left review comments

@dagrayvid dagrayvid Awaiting requested review from dagrayvid

@swatisehgal swatisehgal Awaiting requested review from swatisehgal

Assignees
No one assigned
Labels
bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shaior @yanirq @marioferh