Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add verification on kernel param rcutree.kthread #464

Merged
merged 1 commit into from Sep 16, 2022
Merged

Add verification on kernel param rcutree.kthread #464

merged 1 commit into from Sep 16, 2022

Conversation

shaior
Copy link
Contributor

@shaior shaior commented Sep 12, 2022

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 12, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 12, 2022

@shaior: This pull request references Bugzilla bug 2114681, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to target the "4.12.0" release, but it targets "4.11.z" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is CLOSED (ERRATA) instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2114681: Add verification on kernel param rcutree.kthread

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 12, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 12, 2022

Hi @shaior. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shaior shaior mentioned this pull request Sep 12, 2022
Closed
@shaior shaior changed the title Bug 2114681: Add verification on kernel param rcutree.kthread Add verification on kernel param rcutree.kthread Sep 12, 2022
@openshift-ci openshift-ci bot removed bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 12, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 12, 2022

@shaior: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Add verification on kernel param rcutree.kthread

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yanirq
Copy link
Contributor

yanirq commented Sep 12, 2022

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 12, 2022
marioferh
marioferh reviewed Sep 12, 2022
View reviewed changes
test/e2e/performanceprofile/functests/1_performance/performance.go
@@ -1041,6 +1041,27 @@ var _ = Describe("[rfe_id:27368][performance]", func() {
})
})
})

It("[test_id:54083] Should have kernel param rcutree.kthread", func() {
Copy link
Contributor

@marioferh marioferh Sep 12, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is feasible do it in the same way that the other ones?

It("[test_id:31198] Should set CPU affinity kernel argument", func() { for _, node := range workerRTNodes { cmdline, err := nodes.ExecCommandOnMachineConfigDaemon(&node, []string{"cat", "/proc/cmdline"}) Expect(err).ToNot(HaveOccurred()) // since systemd.cpu_affinity is calculated on node level using tuned we can check only the key in this context. Expect(string(cmdline)).To(ContainSubstring("systemd.cpu_affinity=")) } })

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comment, fixed.

@shaior
Copy link
Contributor Author

shaior commented Sep 12, 2022

/retest

marioferh
marioferh reviewed Sep 13, 2022
View reviewed changes
Copy link
Contributor

@marioferh marioferh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2022
@shaior
Copy link
Contributor Author

shaior commented Sep 14, 2022

/cherry-pick release-4.11

@openshift-cherrypick-robot
Copy link

@shaior: only openshift org members may request cherry-picks. You can still do the cherry-pick manually.

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yanirq
Copy link
Contributor

yanirq commented Sep 14, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shaior, yanirq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD ad3968e and 2 for PR HEAD dffe1b7 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 2a910a7 and 1 for PR HEAD dffe1b7 in total

@shajmakh
Copy link
Contributor

/test e2e-upgrade

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 7d8579b and 0 for PR HEAD dffe1b7 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 16, 2022

@shaior: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 5fc6828 into openshift:master Sep 16, 2022
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 16, 2022
Merged
@openshift-cherrypick-robot
Copy link

@shaior: new pull request created: #472

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

IlyaTyomkin pushed a commit to IlyaTyomkin/cluster-node-tuning-operator that referenced this pull request May 23, 2023
@shaior @IlyaTyomkin
Add verification on kernel param rcutree.kthread (openshift#464)
cfaf607 
remove redundant part

Co-authored-by: shai oren <shaioren@acs48-f01.mgmt.pnr.lab.eng.rdu2.redhat.com>
IlyaTyomkin pushed a commit to IlyaTyomkin/cluster-node-tuning-operator that referenced this pull request Jun 13, 2023
@shaior @IlyaTyomkin
Add verification on kernel param rcutree.kthread (openshift#464)
5242635 
remove redundant part

Co-authored-by: shai oren <shaioren@acs48-f01.mgmt.pnr.lab.eng.rdu2.redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioferh marioferh marioferh left review comments

@jmencak jmencak Awaiting requested review from jmencak

@yanirq yanirq Awaiting requested review from yanirq

Assignees

@marioferh marioferh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@shaior @yanirq @openshift-cherrypick-robot @openshift-ci-robot @shajmakh @marioferh @openshift-merge-robot