-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.13] OCPBUGS-12933: Revert PR558 and PR585 partially #640
[release-4.13] OCPBUGS-12933: Revert PR558 and PR585 partially #640
Conversation
This is a partial revert of openshift#558 openshift#585 that handles different topology of machines in the same MCP. The code was not properly tested on HyperShift and causes a SEGV there.
@openshift-cherrypick-robot: Jira Issue OCPBUGS-12883 has been cloned as Jira Issue OCPBUGS-12933. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-12933, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (liqcui@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmencak, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label backport-risk-assessed |
/retest |
/override ci/prow/e2e-gcp-pao-updating-profile |
/retest |
@jmencak: Overrode contexts on behalf of jmencak: ci/prow/e2e-gcp-pao-updating-profile In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/override ci/prow/e2e-gcp-pao-updating-profile |
@jmencak: Overrode contexts on behalf of jmencak: ci/prow/e2e-gcp-pao-updating-profile In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override ci/prow/e2e-gcp-pao-updating-profile |
@jmencak: Overrode contexts on behalf of jmencak: ci/prow/e2e-gcp-pao-updating-profile In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@liqcui can we get cherry-pick-approved label, please? |
/label cherry-pick-approved |
@openshift-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@openshift-cherrypick-robot: Jira Issue OCPBUGS-12933: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-12933 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build cluster-node-tuning-operator-container-v4.13.0-202305040554.p0.gfa37e0c.assembly.stream for distgit cluster-node-tuning-operator. |
This is an automated cherry-pick of #639
/assign jmencak