Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.13] OCPBUGS-12933: Revert PR558 and PR585 partially #640

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #639

/assign jmencak

This is a partial revert of
openshift#558
openshift#585

that handles different topology of machines in the same MCP.  The code
was not properly tested on HyperShift and causes a SEGV there.
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-12883 has been cloned as Jira Issue OCPBUGS-12933. Will retitle bug to link to clone.
/retitle [release-4.13] OCPBUGS-12933: Revert PR558 and PR585 partially

In response to this:

This is an automated cherry-pick of #639

/assign jmencak

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.13] OCPBUGS-12883: Revert PR558 and PR585 partially [release-4.13] OCPBUGS-12933: Revert PR558 and PR585 partially Apr 29, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 29, 2023

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.13] OCPBUGS-12933: Revert PR558 and PR585 partially

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 29, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-12933, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-12883 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-12883 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (liqcui@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #639

/assign jmencak

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmencak
Copy link
Contributor

jmencak commented Apr 29, 2023

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2023
@jmencak
Copy link
Contributor

jmencak commented Apr 29, 2023

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 29, 2023
@jmencak
Copy link
Contributor

jmencak commented May 3, 2023

/retest

@jmencak
Copy link
Contributor

jmencak commented May 3, 2023

/override ci/prow/e2e-gcp-pao-updating-profile

@jmencak
Copy link
Contributor

jmencak commented May 3, 2023

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 3, 2023

@jmencak: Overrode contexts on behalf of jmencak: ci/prow/e2e-gcp-pao-updating-profile

In response to this:

/override ci/prow/e2e-gcp-pao-updating-profile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmencak
Copy link
Contributor

jmencak commented May 3, 2023

/retest

@jmencak
Copy link
Contributor

jmencak commented May 3, 2023

/override ci/prow/e2e-gcp-pao-updating-profile

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 3, 2023

@jmencak: Overrode contexts on behalf of jmencak: ci/prow/e2e-gcp-pao-updating-profile

In response to this:

/override ci/prow/e2e-gcp-pao-updating-profile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmencak
Copy link
Contributor

jmencak commented May 3, 2023

/override ci/prow/e2e-gcp-pao-updating-profile

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 3, 2023

@jmencak: Overrode contexts on behalf of jmencak: ci/prow/e2e-gcp-pao-updating-profile

In response to this:

/override ci/prow/e2e-gcp-pao-updating-profile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmencak
Copy link
Contributor

jmencak commented May 3, 2023

@liqcui can we get cherry-pick-approved label, please?

@liqcui
Copy link

liqcui commented May 4, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 4, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 4, 2023

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-pao-updating-profile aac21da link true /test e2e-gcp-pao-updating-profile

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit fa37e0c into openshift:release-4.13 May 4, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-12933: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-12933 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #639

/assign jmencak

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.13.0-202305040554.p0.gfa37e0c.assembly.stream for distgit cluster-node-tuning-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants