Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-14622: Do not fail creating cgroups if they exist already #678

Closed
wants to merge 2 commits into from
Closed

OCPBUGS-14622: Do not fail creating cgroups if they exist already #678

wants to merge 2 commits into from

Conversation

v1k0d3n
Copy link
Contributor

@v1k0d3n v1k0d3n commented Jun 6, 2023

This mkdir -p to resolve the issue below:

[root@itamae ~]# systemctl status cpuset-configure.service
× cpuset-configure.service - Move services to reserved cpuset
     Loaded: loaded (/etc/systemd/system/cpuset-configure.service; enabled; preset: disabled)
     Active: failed (Result: exit-code) since Tue 2023-06-06 13:51:43 UTC; 8s ago
    Process: 3927805 ExecStart=/usr/local/bin/cpuset-configure.sh (code=exited, status=1/FAILURE)
   Main PID: 3927805 (code=exited, status=1/FAILURE)
        CPU: 5ms

Jun 06 13:51:43 itamae systemd[1]: Starting Move services to reserved cpuset...
Jun 06 13:51:43 itamae cpuset-configure.sh[3927806]: mkdir: cannot create directory ‘/sys/fs/cgroup/cpuset/system’: File exists
Jun 06 13:51:43 itamae systemd[1]: cpuset-configure.service: Main process exited, code=exited, status=1/FAILURE
Jun 06 13:51:43 itamae systemd[1]: cpuset-configure.service: Failed with result 'exit-code'.
Jun 06 13:51:43 itamae systemd[1]: Failed to start Move services to reserved cpuset.

@v1k0d3n
bug: persistent directory creation
37cb0a9 
Signed-off-by: Brandon B. Jozsa <bjozsa@jinkit.com>
@openshift-ci openshift-ci bot requested review from jmencak and marioferh June 6, 2023 15:25
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 6, 2023

Hi @v1k0d3n. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MarSik
Copy link
Contributor

MarSik commented Jun 6, 2023

/lgtm
/approve
/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 6, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarSik, v1k0d3n

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2023
@v1k0d3n
remove || true for mkdir on machine.slice
54acfb1 
Signed-off-by: Brandon B. Jozsa <bjozsa@jinkit.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2023
@haircommander
Copy link
Member

/lgtm
/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2023
@MarSik
Copy link
Contributor

MarSik commented Jun 6, 2023

/retitle OCPBUGS-14622: Do not fail creating cgroups if they exist already

@openshift-ci openshift-ci bot changed the title bug: persistent directory creation OCPBUGS-14622: Do not fail creating cgroups if they exist already Jun 6, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 6, 2023
@openshift-ci-robot
Copy link
Contributor

@v1k0d3n: This pull request references Jira Issue OCPBUGS-14622, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.13" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This mkdir -p to resolve the issue below:

[root@itamae ~]# systemctl status cpuset-configure.service
× cpuset-configure.service - Move services to reserved cpuset
    Loaded: loaded (/etc/systemd/system/cpuset-configure.service; enabled; preset: disabled)
    Active: failed (Result: exit-code) since Tue 2023-06-06 13:51:43 UTC; 8s ago
   Process: 3927805 ExecStart=/usr/local/bin/cpuset-configure.sh (code=exited, status=1/FAILURE)
  Main PID: 3927805 (code=exited, status=1/FAILURE)
       CPU: 5ms

Jun 06 13:51:43 itamae systemd[1]: Starting Move services to reserved cpuset...
Jun 06 13:51:43 itamae cpuset-configure.sh[3927806]: mkdir: cannot create directory ‘/sys/fs/cgroup/cpuset/system’: File exists
Jun 06 13:51:43 itamae systemd[1]: cpuset-configure.service: Main process exited, code=exited, status=1/FAILURE
Jun 06 13:51:43 itamae systemd[1]: cpuset-configure.service: Failed with result 'exit-code'.
Jun 06 13:51:43 itamae systemd[1]: Failed to start Move services to reserved cpuset.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MarSik
Copy link
Contributor

MarSik commented Jun 6, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 6, 2023
@openshift-ci-robot
Copy link
Contributor

@MarSik: This pull request references Jira Issue OCPBUGS-14622, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (mniranja@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 3d5cdf5 and 2 for PR HEAD 54acfb1 in total

1 similar comment
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 3d5cdf5 and 2 for PR HEAD 54acfb1 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 3d5cdf5 and 2 for PR HEAD 54acfb1 in total

@mrniranjan
Copy link
Contributor

/retest-required

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 262022d and 1 for PR HEAD 54acfb1 in total

@MarSik
Copy link
Contributor

MarSik commented Jun 12, 2023

@v1k0d3n I am pretty sure you need to run make render-sync (https://github.com/openshift/cluster-node-tuning-operator/blob/master/Makefile#L237) to update the test data too. Changing the script is not enough to pass CI.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD ef723ff and 0 for PR HEAD 54acfb1 in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision 54acfb1 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 12, 2023
@haircommander
Copy link
Member

/retest
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 12, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD ef723ff and 2 for PR HEAD 54acfb1 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d4fa19a and 1 for PR HEAD 54acfb1 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 12, 2023

@v1k0d3n: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-no-cluster 54acfb1 link true /test e2e-no-cluster

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ffromani ffromani mentioned this pull request Jun 13, 2023
Merged
@ffromani
Copy link
Contributor

missing fix added in #683

@ffromani
Copy link
Contributor

/close

we merged #683

@openshift-ci openshift-ci bot closed this Jun 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 13, 2023

@ffromani: Closed this PR.

In response to this:

/close

we merged #683

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@v1k0d3n: This pull request references Jira Issue OCPBUGS-14622. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

This mkdir -p to resolve the issue below:

[root@itamae ~]# systemctl status cpuset-configure.service
× cpuset-configure.service - Move services to reserved cpuset
    Loaded: loaded (/etc/systemd/system/cpuset-configure.service; enabled; preset: disabled)
    Active: failed (Result: exit-code) since Tue 2023-06-06 13:51:43 UTC; 8s ago
   Process: 3927805 ExecStart=/usr/local/bin/cpuset-configure.sh (code=exited, status=1/FAILURE)
  Main PID: 3927805 (code=exited, status=1/FAILURE)
       CPU: 5ms

Jun 06 13:51:43 itamae systemd[1]: Starting Move services to reserved cpuset...
Jun 06 13:51:43 itamae cpuset-configure.sh[3927806]: mkdir: cannot create directory ‘/sys/fs/cgroup/cpuset/system’: File exists
Jun 06 13:51:43 itamae systemd[1]: cpuset-configure.service: Main process exited, code=exited, status=1/FAILURE
Jun 06 13:51:43 itamae systemd[1]: cpuset-configure.service: Failed with result 'exit-code'.
Jun 06 13:51:43 itamae systemd[1]: Failed to start Move services to reserved cpuset.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haircommander haircommander haircommander left review comments

@jmencak jmencak Awaiting requested review from jmencak

@marioferh marioferh Awaiting requested review from marioferh

Assignees

@MarSik MarSik

@haircommander haircommander

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@v1k0d3n @MarSik @haircommander @openshift-ci-robot @mrniranjan @ffromani