Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-14622: Do not fail creating cgroups if they exist already #683

Merged
merged 3 commits into from Jun 13, 2023
Merged

OCPBUGS-14622: Do not fail creating cgroups if they exist already #683

merged 3 commits into from Jun 13, 2023

Conversation

ffromani
Copy link
Contributor

This mkdir -p to resolve the issue below:

[root@itamae ~]# systemctl status cpuset-configure.service
× cpuset-configure.service - Move services to reserved cpuset
     Loaded: loaded (/etc/systemd/system/cpuset-configure.service; enabled; preset: disabled)
     Active: failed (Result: exit-code) since Tue 2023-06-06 13:51:43 UTC; 8s ago
    Process: 3927805 ExecStart=/usr/local/bin/cpuset-configure.sh (code=exited, status=1/FAILURE)
   Main PID: 3927805 (code=exited, status=1/FAILURE)
        CPU: 5ms

Jun 06 13:51:43 itamae systemd[1]: Starting Move services to reserved cpuset...
Jun 06 13:51:43 itamae cpuset-configure.sh[3927806]: mkdir: cannot create directory ‘/sys/fs/cgroup/cpuset/system’: File exists
Jun 06 13:51:43 itamae systemd[1]: cpuset-configure.service: Main process exited, code=exited, status=1/FAILURE
Jun 06 13:51:43 itamae systemd[1]: cpuset-configure.service: Failed with result 'exit-code'.
Jun 06 13:51:43 itamae systemd[1]: Failed to start Move services to reserved cpuset.

extends #678

v1k0d3n and others added 3 commits June 6, 2023 11:19
@v1k0d3n
bug: persistent directory creation
37cb0a9 
Signed-off-by: Brandon B. Jozsa <bjozsa@jinkit.com>
@v1k0d3n
remove || true for mkdir on machine.slice
54acfb1 
Signed-off-by: Brandon B. Jozsa <bjozsa@jinkit.com>
@ffromani
test: update test files
67f6687 
run and commit `make render-sync`

Signed-off-by: Francesco Romani <fromani@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jun 13, 2023
@openshift-ci-robot
Copy link
Contributor

@ffromani: This pull request references Jira Issue OCPBUGS-14622, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (mniranja@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This mkdir -p to resolve the issue below:

[root@itamae ~]# systemctl status cpuset-configure.service
× cpuset-configure.service - Move services to reserved cpuset
    Loaded: loaded (/etc/systemd/system/cpuset-configure.service; enabled; preset: disabled)
    Active: failed (Result: exit-code) since Tue 2023-06-06 13:51:43 UTC; 8s ago
   Process: 3927805 ExecStart=/usr/local/bin/cpuset-configure.sh (code=exited, status=1/FAILURE)
  Main PID: 3927805 (code=exited, status=1/FAILURE)
       CPU: 5ms

Jun 06 13:51:43 itamae systemd[1]: Starting Move services to reserved cpuset...
Jun 06 13:51:43 itamae cpuset-configure.sh[3927806]: mkdir: cannot create directory ‘/sys/fs/cgroup/cpuset/system’: File exists
Jun 06 13:51:43 itamae systemd[1]: cpuset-configure.service: Main process exited, code=exited, status=1/FAILURE
Jun 06 13:51:43 itamae systemd[1]: cpuset-configure.service: Failed with result 'exit-code'.
Jun 06 13:51:43 itamae systemd[1]: Failed to start Move services to reserved cpuset.

extends #678

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jun 13, 2023
@ffromani ffromani mentioned this pull request Jun 13, 2023
Closed
@openshift-ci openshift-ci bot requested review from jmencak and marioferh June 13, 2023 06:11
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2023
MarSik
MarSik approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@MarSik MarSik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, MarSik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ffromani
Copy link
Contributor Author

e2e-aws-operator lane seems to have succeeded and failed at the last step. I don't think it's worth a retest for this trivial fix

 INFO[2023-06-13T06:22:13Z] Running step e2e-aws-operator-ipi-conf.      
INFO[2023-06-13T06:22:21Z] Step e2e-aws-operator-ipi-conf succeeded after 8s. 
INFO[2023-06-13T06:22:21Z] Running step e2e-aws-operator-ipi-conf-telemetry. 
INFO[2023-06-13T06:22:30Z] Step e2e-aws-operator-ipi-conf-telemetry succeeded after 8s. 
INFO[2023-06-13T06:22:30Z] Running step e2e-aws-operator-ipi-conf-aws.  
INFO[2023-06-13T06:22:42Z] Step e2e-aws-operator-ipi-conf-aws succeeded after 12s. 
INFO[2023-06-13T06:22:42Z] Running step e2e-aws-operator-ipi-install-monitoringpvc. 
INFO[2023-06-13T06:22:51Z] Step e2e-aws-operator-ipi-install-monitoringpvc succeeded after 8s. 
INFO[2023-06-13T06:22:51Z] Running step e2e-aws-operator-ipi-install-rbac. 
INFO[2023-06-13T06:22:58Z] Step e2e-aws-operator-ipi-install-rbac succeeded after 7s. 
INFO[2023-06-13T06:22:58Z] Running step e2e-aws-operator-openshift-cluster-bot-rbac. 
INFO[2023-06-13T06:23:06Z] Step e2e-aws-operator-openshift-cluster-bot-rbac succeeded after 8s. 
INFO[2023-06-13T06:23:06Z] Running step e2e-aws-operator-ipi-install-hosted-loki. 
INFO[2023-06-13T06:23:14Z] Step e2e-aws-operator-ipi-install-hosted-loki succeeded after 7s. 
INFO[2023-06-13T06:23:14Z] Running step e2e-aws-operator-ipi-install-install. 
INFO[2023-06-13T06:52:21Z] Step e2e-aws-operator-ipi-install-install succeeded after 29m6s. 
INFO[2023-06-13T06:52:21Z] Running step e2e-aws-operator-ipi-install-times-collection. 
INFO[2023-06-13T06:52:30Z] Step e2e-aws-operator-ipi-install-times-collection succeeded after 8s. 
INFO[2023-06-13T06:52:30Z] Step phase pre succeeded after 30m16s.       
INFO[2023-06-13T06:52:30Z] Running multi-stage phase test               
INFO[2023-06-13T06:52:30Z] Running step e2e-aws-operator-test.          
INFO[2023-06-13T07:04:37Z] Step e2e-aws-operator-test succeeded after 12m7s. 
INFO[2023-06-13T07:04:37Z] Step phase test succeeded after 12m7s.       
INFO[2023-06-13T07:04:37Z] Running multi-stage phase post               
INFO[2023-06-13T07:04:37Z] Running step e2e-aws-operator-gather-aws-console. 
INFO[2023-06-13T07:04:57Z] Step e2e-aws-operator-gather-aws-console succeeded after 19s. 
INFO[2023-06-13T07:04:57Z] Running step e2e-aws-operator-gather-must-gather. 
INFO[2023-06-13T07:40:00Z] pod pending for more than 30m0s: containers have not started in 30m0.00044069s: test: 
* Container test is not ready with reason ImageInspectError and message Failed to inspect image "image-registry.openshift-image-registry.svc:5000/ci-op-d8b76mzy/stable@sha256:e8421dfb367c97e000949e6c4777d32522e99023d1db8b4bcbe7ecbd14e5face": rpc error: code = DeadlineExceeded desc = context deadline exceeded

@ffromani
Copy link
Contributor Author

/override ci/prow/e2e-aws-operator

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 13, 2023

@ffromani: Overrode contexts on behalf of ffromani: ci/prow/e2e-aws-operator

In response to this:

/override ci/prow/e2e-aws-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 13, 2023

@ffromani: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit a4c70ab into openshift:master Jun 13, 2023
12 checks passed
@openshift-ci-robot
Copy link
Contributor

@ffromani: Jira Issue OCPBUGS-14622: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-14622 has not been moved to the MODIFIED state.

In response to this:

This mkdir -p to resolve the issue below:

[root@itamae ~]# systemctl status cpuset-configure.service
× cpuset-configure.service - Move services to reserved cpuset
    Loaded: loaded (/etc/systemd/system/cpuset-configure.service; enabled; preset: disabled)
    Active: failed (Result: exit-code) since Tue 2023-06-06 13:51:43 UTC; 8s ago
   Process: 3927805 ExecStart=/usr/local/bin/cpuset-configure.sh (code=exited, status=1/FAILURE)
  Main PID: 3927805 (code=exited, status=1/FAILURE)
       CPU: 5ms

Jun 06 13:51:43 itamae systemd[1]: Starting Move services to reserved cpuset...
Jun 06 13:51:43 itamae cpuset-configure.sh[3927806]: mkdir: cannot create directory ‘/sys/fs/cgroup/cpuset/system’: File exists
Jun 06 13:51:43 itamae systemd[1]: cpuset-configure.service: Main process exited, code=exited, status=1/FAILURE
Jun 06 13:51:43 itamae systemd[1]: cpuset-configure.service: Failed with result 'exit-code'.
Jun 06 13:51:43 itamae systemd[1]: Failed to start Move services to reserved cpuset.

extends #678

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ffromani ffromani deleted the bug-cpuset-configure-script-fixed branch June 13, 2023 08:30
@MarSik
Copy link
Contributor

MarSik commented Jun 13, 2023

/cherry-pick release-4.13

@openshift-cherrypick-robot
Copy link

@MarSik: new pull request created: #684

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarSik MarSik MarSik approved these changes

@jmencak jmencak Awaiting requested review from jmencak

@marioferh marioferh Awaiting requested review from marioferh

Assignees

@MarSik MarSik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ffromani @openshift-ci-robot @MarSik @openshift-cherrypick-robot @openshift-merge-robot @v1k0d3n