Improve render error handling #724
Conversation
When looking for a MachineConfigPool match for each PerformanceProfile we can found no match at all. We should check for this case before using the MCP. This do not detect the root cause of the problem, an invalid PerformanceProfile. To tackle that problem we would need something more deep like a validator.
|
/retest-required |
|
/approve looks a nice improvement anyway to me |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani, jlojosnegros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@jlojosnegros: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/cherry-pick release4.13 |
|
@mrniranjan: cannot checkout In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.13 |
|
@mrniranjan: new pull request created: #755 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
… MCP" This was fixed in a better way by openshift#724 This reverts commit e54e169.
… MCP" This was fixed in a better way by openshift#724 This reverts commit e54e169.
This reverts commit 75e8a95.
When looking for a MachineConfigPool match for each PerformanceProfile we can found no match at all.
We should check for this case before using the MCP.
This do not detect the root cause of the problem, an invalid PerformanceProfile. To tackle that problem we would need something more deep like a validator.