Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve render error handling #724

Merged
merged 1 commit into from Jul 25, 2023
Merged

Improve render error handling #724

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions pkg/performanceprofile/cmd/render/render.go
View file
Open in desktop
Expand Up @@ -156,6 +156,11 @@ func render(inputDir, outputDir string) error {
return err
}

if mcp == nil {
klog.Infof("render: No MachineConfigPool found for PerformanceProfile %s", pp.Name)
continue
}

defaultRuntime, err := getContainerRuntimeName(pp, mcp, ctrcfgs)
if err != nil {
return fmt.Errorf("render: could not determine high-performance runtime class container-runtime for profile %q; %w", pp.Name, err)
Expand Down