Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-16348: OSLAT latency spikes due to tsc karg setting #756

Merged
merged 3 commits into from Aug 13, 2023

Conversation

browsell
Copy link
Contributor

Signed-off-by: Brent Rowsell browsell@redhat.com

A RHEL 9.x change added a timer to make sure TSC_adjust is always which introduces latency spikes. Update tsc karg to tsc=reliable. This aligns with the realtime tuned profile.

Signed-off-by: Brent Rowsell <browsell@redhat.com>

A RHEL 9.x change added a timer to make sure TSC_adjust is always
which introduces latency spikes. Update tsc karg to tsc=reliable.
This aligns with the realtime tuned profile.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 12, 2023
@openshift-ci-robot
Copy link
Contributor

@browsell: This pull request references Jira Issue OCPBUGS-16348, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Signed-off-by: Brent Rowsell browsell@redhat.com

A RHEL 9.x change added a timer to make sure TSC_adjust is always which introduces latency spikes. Update tsc karg to tsc=reliable. This aligns with the realtime tuned profile.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 12, 2023
@openshift-ci openshift-ci bot requested review from jmencak and Tal-or August 12, 2023 13:33
@browsell
Copy link
Contributor Author

/retest

Signed-off-by: Brent Rowsell browsell@redhat.com
@browsell
Copy link
Contributor Author

/test unit

Signed-off-by: Brent Rowsell <browsell@redhat.com>

Update tests
@browsell
Copy link
Contributor Author

/test e2e-gcp-pao-workloadhints

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 12, 2023

@browsell: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@browsell
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@browsell: This pull request references Jira Issue OCPBUGS-16348, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@browsell
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@browsell: This pull request references Jira Issue OCPBUGS-16348, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@browsell
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Aug 13, 2023
@openshift-ci-robot
Copy link
Contributor

@browsell: This pull request references Jira Issue OCPBUGS-16348, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gsr-shanks

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 13, 2023
@openshift-ci openshift-ci bot requested a review from gsr-shanks August 13, 2023 14:40
@jmencak
Copy link
Contributor

jmencak commented Aug 13, 2023

Based on the OCPBUG
/assign @MarSik

@yanirq
Copy link
Contributor

yanirq commented Aug 13, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: browsell, yanirq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2023
@openshift-merge-robot openshift-merge-robot merged commit 1ca4848 into openshift:master Aug 13, 2023
13 checks passed
@openshift-ci-robot
Copy link
Contributor

@browsell: Jira Issue OCPBUGS-16348: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-16348 has been moved to the MODIFIED state.

In response to this:

Signed-off-by: Brent Rowsell browsell@redhat.com

A RHEL 9.x change added a timer to make sure TSC_adjust is always which introduces latency spikes. Update tsc karg to tsc=reliable. This aligns with the realtime tuned profile.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yanirq
Copy link
Contributor

yanirq commented Aug 13, 2023

/cherry-pick release-4.13

@openshift-cherrypick-robot

@yanirq: #756 failed to apply on top of branch "release-4.13":

Applying: OCPBUGS-16348: OSLAT latency spikes due to tsc karg setting Signed-off-by: Brent Rowsell <browsell@redhat.com>
Applying: OCPBUGS-16348: Update Unit test Signed-off-by: Brent Rowsell browsell@redhat.com
Applying: OCPBUGS-16348: OSLAT latency spikes due to tsc karg setting Signed-off-by: Brent Rowsell <browsell@redhat.com>
Using index info to reconstruct a base tree...
A	test/e2e/performanceprofile/functests/8_performance_workloadhints/workloadhints.go
M	test/e2e/performanceprofile/testdata/render-expected-output/manual_tuned.yaml
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/performanceprofile/testdata/render-expected-output/manual_tuned.yaml
CONFLICT (modify/delete): test/e2e/performanceprofile/functests/8_performance_workloadhints/workloadhints.go deleted in HEAD and modified in OCPBUGS-16348: OSLAT latency spikes due to tsc karg setting Signed-off-by: Brent Rowsell <browsell@redhat.com>. Version OCPBUGS-16348: OSLAT latency spikes due to tsc karg setting Signed-off-by: Brent Rowsell <browsell@redhat.com> of test/e2e/performanceprofile/functests/8_performance_workloadhints/workloadhints.go left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0003 OCPBUGS-16348: OSLAT latency spikes due to tsc karg setting Signed-off-by: Brent Rowsell <browsell@redhat.com>
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants