Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-16348: OSLAT latency spikes due to tsc karg setting #756

Merged
merged 3 commits into from
Aug 13, 2023
Merged

OCPBUGS-16348: OSLAT latency spikes due to tsc karg setting #756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80dba8f
OCPBUGS-16348: OSLAT latency spikes due to tsc karg setting
Aug 11, 2023
09afaaf
OCPBUGS-16348: Update Unit test
Aug 12, 2023
031cf03
OCPBUGS-16348: OSLAT latency spikes due to tsc karg setting
Aug 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/performanceprofile/tuned/openshift-node-performance
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ cmdline_isolation=+isolcpus=managed_irq,${isolated_cores}
{{end}}

{{if .RealTimeHint}}
cmdline_realtime=+nohz_full=${isolated_cores} tsc=nowatchdog nosoftlockup nmi_watchdog=0 mce=off skew_tick=1 rcutree.kthread_prio=11
cmdline_realtime=+nohz_full=${isolated_cores} tsc=reliable nosoftlockup nmi_watchdog=0 mce=off skew_tick=1 rcutree.kthread_prio=11
{{end}}

{{if .HighPowerConsumption}}
Expand Down
2 changes: 1 addition & 1 deletion pkg/performanceprofile/controller/performanceprofile/components/tuned/tuned_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ var (
cmdlineCPUsPartitioning = "+nohz=on rcu_nocbs=${isolated_cores} tuned.non_isolcpus=${not_isolated_cpumask} systemd.cpu_affinity=${not_isolated_cores_expanded} intel_iommu=on iommu=pt"
cmdlineWithStaticIsolation = "+isolcpus=domain,managed_irq,${isolated_cores}"
cmdlineWithoutStaticIsolation = "+isolcpus=managed_irq,${isolated_cores}"
cmdlineRealtime = "+nohz_full=${isolated_cores} tsc=nowatchdog nosoftlockup nmi_watchdog=0 mce=off skew_tick=1 rcutree.kthread_prio=11"
cmdlineRealtime = "+nohz_full=${isolated_cores} tsc=reliable nosoftlockup nmi_watchdog=0 mce=off skew_tick=1 rcutree.kthread_prio=11"
cmdlineHighPowerConsumption = "+processor.max_cstate=1 intel_idle.max_cstate=0"
cmdlineIdlePoll = "+idle=poll"
cmdlineHugepages = "+ default_hugepagesz=1G hugepagesz=1G hugepages=4"
Expand Down
14 changes: 7 additions & 7 deletions test/e2e/performanceprofile/functests/8_performance_workloadhints/workloadhints.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ var _ = Describe("[rfe_id:49062][workloadHints] Telco friendly workload specific
"kernel.sched_rt_runtime_us": "-1",
"vm.stat_interval": "10",
}
kernelParameters := []string{noHzParam, "tsc=nowatchdog", "nosoftlockup", "nmi_watchdog=0", "mce=off", "skew_tick=1"}
kernelParameters := []string{noHzParam, "tsc=reliable", "nosoftlockup", "nmi_watchdog=0", "mce=off", "skew_tick=1"}

wg := sync.WaitGroup{}
By("Waiting for TuneD to start on nodes")
Expand Down Expand Up @@ -163,7 +163,7 @@ var _ = Describe("[rfe_id:49062][workloadHints] Telco friendly workload specific
"kernel.sched_rt_runtime_us": "-1",
"vm.stat_interval": "10",
}
kernelParameters := []string{noHzParam, "tsc=nowatchdog", "nosoftlockup", "nmi_watchdog=0", "mce=off", "skew_tick=1"}
kernelParameters := []string{noHzParam, "tsc=reliable", "nosoftlockup", "nmi_watchdog=0", "mce=off", "skew_tick=1"}

wg := sync.WaitGroup{}
By("Waiting for TuneD to start on nodes")
Expand Down Expand Up @@ -281,7 +281,7 @@ var _ = Describe("[rfe_id:49062][workloadHints] Telco friendly workload specific
"kernel.sched_rt_runtime_us": "-1",
"vm.stat_interval": "10",
}
kernelParameters := []string{noHzParam, "tsc=nowatchdog", "nosoftlockup", "nmi_watchdog=0", "mce=off", "skew_tick=1",
kernelParameters := []string{noHzParam, "tsc=reliable", "nosoftlockup", "nmi_watchdog=0", "mce=off", "skew_tick=1",
"processor.max_cstate=1", "intel_idle.max_cstate=0", "intel_pstate=disable", "idle=poll"}

wg := sync.WaitGroup{}
Expand Down Expand Up @@ -398,7 +398,7 @@ var _ = Describe("[rfe_id:49062][workloadHints] Telco friendly workload specific
"kernel.sched_rt_runtime_us": "-1",
"vm.stat_interval": "10",
}
kernelParameters := []string{noHzParam, "tsc=nowatchdog", "nosoftlockup", "nmi_watchdog=0", "mce=off", "skew_tick=1",
kernelParameters := []string{noHzParam, "tsc=reliable", "nosoftlockup", "nmi_watchdog=0", "mce=off", "skew_tick=1",
"processor.max_cstate=1", "intel_idle.max_cstate=0", "intel_pstate=disable", "idle=poll"}

wg := sync.WaitGroup{}
Expand Down Expand Up @@ -463,7 +463,7 @@ var _ = Describe("[rfe_id:49062][workloadHints] Telco friendly workload specific
"kernel.sched_rt_runtime_us": "-1",
"vm.stat_interval": "10",
}
kernelParameters = []string{noHzParam, "tsc=nowatchdog", "nosoftlockup", "nmi_watchdog=0", "mce=off", "skew_tick=1", "intel_pstate=passive"}
kernelParameters = []string{noHzParam, "tsc=reliable", "nosoftlockup", "nmi_watchdog=0", "mce=off", "skew_tick=1", "intel_pstate=passive"}

wg = sync.WaitGroup{}
By("Waiting for TuneD to start on nodes")
Expand Down Expand Up @@ -534,7 +534,7 @@ var _ = Describe("[rfe_id:49062][workloadHints] Telco friendly workload specific
"kernel.sched_rt_runtime_us": "-1",
"vm.stat_interval": "10",
}
kernelParameters := []string{noHzParam, "tsc=nowatchdog", "nosoftlockup", "nmi_watchdog=0", "mce=off", "skew_tick=1", "intel_pstate=passive"}
kernelParameters := []string{noHzParam, "tsc=reliable", "nosoftlockup", "nmi_watchdog=0", "mce=off", "skew_tick=1", "intel_pstate=passive"}

wg := sync.WaitGroup{}
By("Waiting for TuneD to start on nodes")
Expand Down Expand Up @@ -598,7 +598,7 @@ var _ = Describe("[rfe_id:49062][workloadHints] Telco friendly workload specific
"kernel.sched_rt_runtime_us": "-1",
"vm.stat_interval": "10",
}
kernelParameters = []string{noHzParam, "tsc=nowatchdog", "nosoftlockup", "nmi_watchdog=0", "mce=off", "skew_tick=1",
kernelParameters = []string{noHzParam, "tsc=reliable", "nosoftlockup", "nmi_watchdog=0", "mce=off", "skew_tick=1",
"processor.max_cstate=1", "intel_idle.max_cstate=0", "intel_pstate=disable", "idle=poll"}

wg = sync.WaitGroup{}
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/performanceprofile/testdata/render-expected-output/manual_tuned.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ spec:
overrides cpu-partitioning cmdline\ncmdline_cpu_part=+nohz=on rcu_nocbs=${isolated_cores}
tuned.non_isolcpus=${not_isolated_cpumask} systemd.cpu_affinity=${not_isolated_cores_expanded}
intel_iommu=on iommu=pt\n\n\ncmdline_isolation=+isolcpus=managed_irq,${isolated_cores}\n\n\n\ncmdline_realtime=+nohz_full=${isolated_cores}
tsc=nowatchdog nosoftlockup nmi_watchdog=0 mce=off skew_tick=1 rcutree.kthread_prio=11\n\n\n\n\n\n\n\ncmdline_hugepages=+
tsc=reliable nosoftlockup nmi_watchdog=0 mce=off skew_tick=1 rcutree.kthread_prio=11\n\n\n\n\n\n\n\ncmdline_hugepages=+
default_hugepagesz=1G hugepagesz=2M hugepages=128 \n\n\n\n\ncmdline_pstate=+intel_pstate=disable\n\n"
name: openshift-node-performance-manual
recommend:
Expand Down