Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.14] OCPBUGS-21845: e2e:rps: improve logging #831

Merged
merged 3 commits into from Nov 30, 2023
Merged

[release-4.14] OCPBUGS-21845: e2e:rps: improve logging #831

merged 3 commits into from Nov 30, 2023

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #787

/assign yanirq

@Tal-or
e2e:rps: log the expected rps mask
9315ff3 
print the expected rps mask for physical and virtual network devices.
This change would help with debugging the test in case of failure.

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
@Tal-or
e2e:rps: print mask instead of cpuset
e68bd9b 
Printing the rps masks in case of failure is more readable then printing the cpuset.
this is because an empty mask i.e 0000 is interpeted as an empty cpuset i.e "" (empty quotes)

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
@Tal-or
e2e:rps: print device path with wrong mask
ef01075 
In case the test failed, we asserts only the desired and actual mask,
but we are not specifing the device on which the RPS mask was bad.

This patch adds the full device path as part of the error message.

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 17, 2023
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-18662 has been cloned as Jira Issue OCPBUGS-21845. Will retitle bug to link to clone.
/retitle [release-4.14] OCPBUGS-21845: e2e:rps: improve logging

In response to this:

This is an automated cherry-pick of #787

/assign yanirq

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.14] OCPBUGS-18662: e2e:rps: improve logging [release-4.14] OCPBUGS-21845: e2e:rps: improve logging Oct 17, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 17, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-21845, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-18662 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-18662 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

Requesting review from QA contact:
/cc @gsr-shanks

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #787

/assign yanirq

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Tal-or
Copy link
Contributor

Tal-or commented Oct 18, 2023

/retest

@Tal-or
Copy link
Contributor

Tal-or commented Nov 2, 2023

/cc @yanirq

@openshift-ci openshift-ci bot requested a review from yanirq November 2, 2023 16:39
@Tal-or
Copy link
Contributor

Tal-or commented Nov 2, 2023

/cc @mrniranjan Please add the relevant labels if possible

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 2, 2023

@Tal-or: GitHub didn't allow me to request PR reviews from the following users: add, the, relevant, if, possible, Please.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @mrniranjan Please add the relevant labels if possible

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Tal-or Tal-or mentioned this pull request Nov 13, 2023
Merged
@shajmakh
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 13, 2023
@Tal-or
Copy link
Contributor

Tal-or commented Nov 13, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2023
@ffromani
Copy link
Contributor

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2023
@MarSik
Copy link
Contributor

MarSik commented Nov 30, 2023

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 30, 2023
@Tal-or
Copy link
Contributor

Tal-or commented Nov 30, 2023

/test e2e-gcp-pao-updating-profile

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 1e657ec and 2 for PR HEAD ef01075 in total

@Tal-or
Copy link
Contributor

Tal-or commented Nov 30, 2023

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 30, 2023

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit ab65a08 into openshift:release-4.14 Nov 30, 2023
13 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-21845: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-21845 has not been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #787

/assign yanirq

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.14.0-202311302050.p0.gab65a08.assembly.stream for distgit cluster-node-tuning-operator.
All builds following this will include this PR.

@Tal-or
Copy link
Contributor

Tal-or commented Dec 3, 2023

/cherry pick release-4.13

@Tal-or
Copy link
Contributor

Tal-or commented Dec 3, 2023

/cherry-pick release-4.13

@openshift-cherrypick-robot
Copy link
Author

@Tal-or: #831 failed to apply on top of branch "release-4.13":

Applying: e2e:rps: log the expected rps mask
Using index info to reconstruct a base tree...
M	test/e2e/performanceprofile/functests/1_performance/performance.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/performanceprofile/functests/1_performance/performance.go
CONFLICT (content): Merge conflict in test/e2e/performanceprofile/functests/1_performance/performance.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 e2e:rps: log the expected rps mask
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Tal-or Tal-or mentioned this pull request Dec 3, 2023
Merged
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.14.0-0.nightly-2023-12-03-135752

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsr-shanks gsr-shanks Awaiting requested review from gsr-shanks

@dagrayvid dagrayvid Awaiting requested review from dagrayvid

@MarSik MarSik Awaiting requested review from MarSik

@yanirq yanirq Awaiting requested review from yanirq

@mrniranjan mrniranjan Awaiting requested review from mrniranjan

Assignees

@yanirq yanirq

@Tal-or Tal-or

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@openshift-cherrypick-robot @openshift-ci-robot @Tal-or @shajmakh @ffromani @MarSik @openshift-bot @openshift-merge-robot @yanirq