[release-4.13] [manual] OCPBUGS-24353:rps:cherry-picks of rps fixes #865
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@Tal-or: This pull request references Jira Issue OCPBUGS-24353, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cc @yanirq |
|
/jira refresh |
|
@Tal-or: This pull request references Jira Issue OCPBUGS-24353, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmencak, Tal-or The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
|
/lgtm |
|
/label backport-risk-assessed |
openshift-ci
bot
added
the
backport-risk-assessed
|
/cc @shajmakh @mrniranjan |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
@Tal-or do we still need to hold this PR ? |
Tal-or
force-pushed
the
rps_bug_fix_manual_backport
branch
from
37d0d95
to
47e97df
Compare
Tal-or
changed the title
This commit sqush couple of backported commits from newer versions that suppose to fix all the various rps issues we had in the past. The fixes are as follow: 1. Instead of trigger udev event per physical device creation, triggers it per queue creation so in case of queue resize (i.e. more queues are added) it applies the correct rps mask on the new created queues as well. 2. fix mask update for SR-IOV devices * rps:udev: escape systemd unit name The journal spammed by warnings about the fact that systemd unit name is not escaped. we use systemd-escape in order to escape the unit-name properly. `--path` is for telling systemd-escape that the input is a valid file path name. `--template` is telling systemd-escape to inserts the escaped strings in a unit name template. %c accepts the output of `PROGRAM` * rps:udev: act upon move action SR-IOV devices get moved (renamed) upon their creation. This causes the `set-rps-mask.sh` to fail since the queue's path has changed. We should add additional udev rule to act upon the move of a physical device and set the rps mask correctly. The `set-rps-mask.sh` script has modified to act upon those two different scenarios: a. when queues are being added. b. when net device is moved. In addition we fail silently (return 0) when queues are failed to get updated due to the mentioned above. The queues that were failed to get updated, are expected to be updated by the instance that get trrigered after the device move (renaming). 3. rps: fail silently when rps application failed In case the device gets removed completely, We want to hide the error, becuase we should not care of applying rps mask for devices which are gone anyway. Signed-off-by: Talor Itzhak <titzhak@redhat.com>
Tal-or
force-pushed
the
rps_bug_fix_manual_backport
branch
from
47e97df
to
d034900
Compare
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/uncc @marioferh |
|
/retest |
|
@Tal-or: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/jira refresh |
|
@Tal-or: This pull request references Jira Issue OCPBUGS-24353, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@Tal-or: This pull request references Jira Issue OCPBUGS-24353, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
openshift-merge-bot
bot
merged commit 4ce5b75
into
openshift:release-4.13
|
@Tal-or: Jira Issue OCPBUGS-24353: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-24353 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build cluster-node-tuning-operator-container-v4.13.0-202402211438.p0.g4ce5b75.assembly.stream.el9 for distgit cluster-node-tuning-operator. |
|
Fix included in accepted release 4.13.0-0.nightly-2024-02-22-101141 |
Manual backport of: