Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.14] OCPBUGS-22752: Disable HTTP/2 for webhook and metrics servers #841

Merged
merged 1 commit into from Nov 2, 2023
Merged

[release-4.14] OCPBUGS-22752: Disable HTTP/2 for webhook and metrics servers #841

merged 1 commit into from Nov 2, 2023

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #834

/assign jmencak

@jmencak
Disable HTTP/2 for webhook and metrics servers
42e92d4 
Remove HTTP/2 support for webhook and metrics servers -- mitigation for
CVE-2023-44487.

Resolves: OCPBUGS-21932
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 31, 2023
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-21932 has been cloned as Jira Issue OCPBUGS-22752. Will retitle bug to link to clone.
/retitle [release-4.14] OCPBUGS-22752: Disable HTTP/2 for webhook and metrics servers

In response to this:

This is an automated cherry-pick of #834

/assign jmencak

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.14] OCPBUGS-21932: Disable HTTP/2 for webhook and metrics servers [release-4.14] OCPBUGS-22752: Disable HTTP/2 for webhook and metrics servers Oct 31, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 31, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-22752, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-21932 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-21932 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (liqcui@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #834

/assign jmencak

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Oct 31, 2023
@openshift-ci openshift-ci bot requested review from kpouget and MarSik October 31, 2023 15:17
@ffromani
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 31, 2023

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jmencak
Copy link
Contributor

jmencak commented Oct 31, 2023

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2023
@jmencak
Copy link
Contributor

jmencak commented Nov 2, 2023

/label backport-risk-assessed
@liqcui , can we please have cherry-pick-approved label?

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 2, 2023
@liqcui
Copy link

liqcui commented Nov 2, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 2, 2023
@openshift-ci openshift-ci bot merged commit 9669c58 into openshift:release-4.14 Nov 2, 2023
13 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-22752: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-22752 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #834

/assign jmencak

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmencak jmencak mentioned this pull request Nov 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpouget kpouget Awaiting requested review from kpouget

@MarSik MarSik Awaiting requested review from MarSik

Assignees

@jmencak jmencak

@ffromani ffromani

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@openshift-cherrypick-robot @openshift-ci-robot @ffromani @jmencak @liqcui