Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-20669: Disable HTTP/2 for webhook and metrics servers #846

Merged
merged 1 commit into from Nov 13, 2023
Merged

OCPBUGS-20669: Disable HTTP/2 for webhook and metrics servers #846

merged 1 commit into from Nov 13, 2023

Conversation

jmencak
Copy link
Contributor

@jmencak jmencak commented Nov 8, 2023 •
edited

Remove HTTP/2 support for webhook and metrics servers -- mitigation for CVE-2023-44487. controller-runtime was upgraded to add support for TLSOpts.

Resolves: OCPBUGS-20669

This is a backport of #841

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2023
@jmencak jmencak changed the title Disable HTTP/2 for webhook and metrics servers OCPBUGS-20669: Disable HTTP/2 for webhook and metrics servers Nov 8, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Nov 8, 2023
@openshift-ci-robot
Copy link
Contributor

@jmencak: This pull request references Jira Issue OCPBUGS-20669, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-22752 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-22752 targets the "4.14.z" version, which is one of the valid target versions: 4.14.0, 4.14.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (liqcui@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Remove HTTP/2 support for webhook and metrics servers -- mitigation for CVE-2023-44487. controller-runtime was upgraded to add support for TLSOpts.

Resolves: OCPBUGS-20669

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@jmencak: This pull request references Jira Issue OCPBUGS-20669, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-22752 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-22752 targets the "4.14.z" version, which is one of the valid target versions: 4.14.0, 4.14.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (liqcui@redhat.com), skipping review request.

In response to this:

Remove HTTP/2 support for webhook and metrics servers -- mitigation for CVE-2023-44487. controller-runtime was upgraded to add support for TLSOpts.

Resolves: OCPBUGS-20669

This is a backport of #841

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmencak
Copy link
Contributor Author

jmencak commented Nov 8, 2023

This is a backport of #841 that @ffromani reviewed.

@jmencak
Disable HTTP/2 for webhook and metrics servers
38358b5 
Remove HTTP/2 support for webhook and metrics servers -- mitigation for
CVE-2023-44487.  controller-runtime was upgraded to add support for
TLSOpts.

Resolves: OCPBUGS-20669
@jmencak jmencak force-pushed the 4.13-CVE-2023-44487-rapid-reset branch from 899b16f to 38358b5 Compare November 9, 2023 06:47
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 9, 2023

@jmencak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ffromani
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2023
@jmencak
Copy link
Contributor Author

jmencak commented Nov 13, 2023

/label backport-risk-assessed
@liqcui , can we please have cherry-pick-approved label for this, please? Thank you!

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 13, 2023
@liqcui
Copy link

liqcui commented Nov 13, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 13, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 05a417a into openshift:release-4.13 Nov 13, 2023
11 checks passed
@openshift-ci-robot
Copy link
Contributor

@jmencak: Jira Issue OCPBUGS-20669: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-20669 has been moved to the MODIFIED state.

In response to this:

Remove HTTP/2 support for webhook and metrics servers -- mitigation for CVE-2023-44487. controller-runtime was upgraded to add support for TLSOpts.

Resolves: OCPBUGS-20669

This is a backport of #841

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmencak jmencak deleted the 4.13-CVE-2023-44487-rapid-reset branch November 13, 2023 12:48
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.13.0-202311131234.p0.g05a417a.assembly.stream for distgit cluster-node-tuning-operator.
All builds following this will include this PR.

@jmencak jmencak mentioned this pull request Nov 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swatisehgal swatisehgal Awaiting requested review from swatisehgal

@Tal-or Tal-or Awaiting requested review from Tal-or

Assignees

@ffromani ffromani

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jmencak @openshift-ci-robot @ffromani @liqcui @openshift-bot