Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNF-10786:e2e: general improvements and cleanup #898

Merged
merged 5 commits into from Jan 16, 2024
Merged

CNF-10786:e2e: general improvements and cleanup #898

merged 5 commits into from Jan 16, 2024

Conversation

Tal-or
Copy link
Contributor

@Tal-or Tal-or commented Dec 25, 2023

Set of API updates, best practices adoption and cleanup to the e2e suite:

  • Replacing pointer package API
  • Passing contexts from the caller functions
  • Removing unused functions

@Tal-or Tal-or changed the title e2e: general improvements and cleanup CNF-10786:e2e: general improvements and cleanup Dec 26, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 26, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 26, 2023 •
edited by openshift-ci bot

@Tal-or: This pull request references CNF-10786 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Set of API updates, best practices adoption and cleanup to the e2e suite:

  • Replacing pointer package API
  • Passing contexts from the caller functions
  • Removing unused functions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ffromani
ffromani reviewed Jan 2, 2024
View reviewed changes
Copy link
Contributor

@ffromani ffromani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using PollUntilContextTimeout is a step in the right direction but it won't help us much until we complete the wiring, passing ctx from the top level down to the latest helper. I'm not sure we're there, even including this change. Nevertheless, let's do this step.

test/e2e/performanceprofile/functests/11_mixedcpus/mixedcpus.go Outdated Show resolved Hide resolved
@Tal-or
Copy link
Contributor Author

Tal-or commented Jan 2, 2024

using PollUntilContextTimeout is a step in the right direction but it won't help us much until we complete the wiring, passing ctx from the top level down to the latest helper. I'm not sure we're there, even including this change. Nevertheless, let's do this step.

This is done on later commits in this PR.

@Tal-or
Copy link
Contributor Author

Tal-or commented Jan 3, 2024

/retest

1 similar comment
@Tal-or
Copy link
Contributor Author

Tal-or commented Jan 4, 2024

/retest

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 4, 2024
@Tal-or
pointer: replace pointer package API
06942ff 
The new API removes the Ptr suffix from the function name.
Updating the code to comply with the new API

No intended changes in the existing behavior.

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
@Tal-or
e2e: replace wait function to use context
ea9d032 
Replace `PollImmediate` with `PollUntilWithContextTimeout` which return
errors from context.

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
@Tal-or
e2e: pass context from the caller
45b0d93 
Following the e2e best practices,
we pass a context to all functions from the main execution thread.

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
@Tal-or
e2e: remove unused functions
fc4801e 
Signed-off-by: Talor Itzhak <titzhak@redhat.com>
@Tal-or
e2e: remove redundant parentheses and type conversions
2fe3d7f 
Signed-off-by: Talor Itzhak <titzhak@redhat.com>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 9, 2024
@Tal-or
Copy link
Contributor Author

Tal-or commented Jan 9, 2024

/test e2e-hypershift

@Tal-or
Copy link
Contributor Author

Tal-or commented Jan 9, 2024

/retest

ffromani
ffromani reviewed Jan 9, 2024
View reviewed changes
Copy link
Contributor

@ffromani ffromani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ffromani
Copy link
Contributor

ffromani commented Jan 9, 2024

/cc @jmencak

because this PR is changing mostly perfprof-related code, but also some generic NTO tests

@openshift-ci openshift-ci bot requested a review from jmencak January 9, 2024 16:34
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2024
@Tal-or
Copy link
Contributor Author

Tal-or commented Jan 9, 2024

/retest

@jmencak
Copy link
Contributor

jmencak commented Jan 9, 2024

Thank you for the PR
/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak, Tal-or

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 7820510 and 2 for PR HEAD 2fe3d7f in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD cff2950 and 1 for PR HEAD 2fe3d7f in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD dfc37fc and 0 for PR HEAD 2fe3d7f in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 16, 2024

@Tal-or: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit b185119 into openshift:master Jan 16, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffromani ffromani ffromani left review comments

@kpouget kpouget Awaiting requested review from kpouget

@jmencak jmencak Awaiting requested review from jmencak

Assignees

@ffromani ffromani

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Tal-or @openshift-ci-robot @ffromani @jmencak @openshift-merge-robot