-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNF-10786:e2e: general improvements and cleanup #898
Conversation
@Tal-or: This pull request references CNF-10786 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using PollUntilContextTimeout
is a step in the right direction but it won't help us much until we complete the wiring, passing ctx
from the top level down to the latest helper. I'm not sure we're there, even including this change. Nevertheless, let's do this step.
test/e2e/performanceprofile/functests/11_mixedcpus/mixedcpus.go
Outdated
Show resolved
Hide resolved
This is done on later commits in this PR. |
/retest |
1 similar comment
/retest |
The new API removes the Ptr suffix from the function name. Updating the code to comply with the new API No intended changes in the existing behavior. Signed-off-by: Talor Itzhak <titzhak@redhat.com>
Replace `PollImmediate` with `PollUntilWithContextTimeout` which return errors from context. Signed-off-by: Talor Itzhak <titzhak@redhat.com>
Following the e2e best practices, we pass a context to all functions from the main execution thread. Signed-off-by: Talor Itzhak <titzhak@redhat.com>
Signed-off-by: Talor Itzhak <titzhak@redhat.com>
Signed-off-by: Talor Itzhak <titzhak@redhat.com>
/test e2e-hypershift |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/cc @jmencak because this PR is changing mostly perfprof-related code, but also some generic NTO tests |
/retest |
Thank you for the PR |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmencak, Tal-or The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Tal-or: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Set of API updates, best practices adoption and cleanup to the e2e suite: