[release-4.15][manual] OCPBUGS-27227: irqbalance: set banned cpus list to '0' #953
Conversation
Empty irqbalance ban list means that irqbalance will be calculated by default. The default will exclude all isolated and nohz_full cpus from the mask resulting in the irq’s being balanced over the reserved cpus only, breaking the user intent. CPU numbers which have their corresponding bits set to one in the ban mask will not have any irq's assigned to them on rebalance. Then we should set the mask to zero, so all cpus will participate in load balancing. Signed-off-by: Talor Itzhak <titzhak@redhat.com>
According to https://github.com/koalaman/shellcheck/wiki/SC2070 `-n` doesn\'t work with unquoted arguments. In addition it's safer to always evaluate variables in quotes to avoid word splitting and globbing, so let\'s fix that as well. Signed-off-by: Talor Itzhak <titzhak@redhat.com>
Now the tests should look for \'0\' as the default value of the banned list, and fail otherwise. Signed-off-by: Talor Itzhak <titzhak@redhat.com>
Signed-off-by: Talor Itzhak <titzhak@redhat.com>
openshift-ci-robot
added
jira/severity-important
|
@Tal-or: This pull request references Jira Issue OCPBUGS-27227, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/approve |
openshift-ci
bot
added
the
backport-risk-assessed
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Tal-or, yanirq The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
@Tal-or: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 9a9323f
into
openshift:release-4.15
|
@Tal-or: Jira Issue OCPBUGS-27227: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-27227 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build cluster-node-tuning-operator-container-v4.15.0-202402140238.p0.g9a9323f.assembly.stream.el9 for distgit cluster-node-tuning-operator. |
|
Fix included in accepted release 4.15.0-0.nightly-2024-02-14-103043 |
Manual cherry-pick of #899