New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.14][manual] OCPBUGS-30980: irqbalance: set banned cpus list to '0' #994
[release-4.14][manual] OCPBUGS-30980: irqbalance: set banned cpus list to '0' #994
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yanirq The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@yanirq: once the present PR merges, I will cherry-pick it on top of OCPBUGS-27227 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira cherrypick OCPBUGS-27227 |
@yanirq: Jira Issue OCPBUGS-27227 has been cloned as Jira Issue OCPBUGS-30980. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@yanirq: This pull request references Jira Issue OCPBUGS-30980, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/uncc @gsr-shanks |
Empty irqbalance ban list means that irqbalance will be calculated by default. The default will exclude all isolated and nohz_full cpus from the mask resulting in the irq’s being balanced over the reserved cpus only, breaking the user intent. CPU numbers which have their corresponding bits set to one in the ban mask will not have any irq's assigned to them on rebalance. Then we should set the mask to zero, so all cpus will participate in load balancing.
@yanirq: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/label backport-risk-assessed |
/lgtm |
/label cherry-pick-approved |
d8d9739
into
openshift:release-4.14
@yanirq: Jira Issue OCPBUGS-30980: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-30980 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build cluster-node-tuning-operator-container-v4.14.0-202403191142.p0.gd8d9739.assembly.stream.el9 for distgit cluster-node-tuning-operator. |
/cherry-pick release-4.13 |
@yanirq: #994 failed to apply on top of branch "release-4.13":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Empty irqbalance ban list means that irqbalance will be calculated by default. The default will exclude all isolated and nohz_full cpus from the mask resulting in the irq’s being balanced over the reserved cpus only, breaking the user intent. CPU numbers which have their corresponding bits set to one in the ban mask will not have any irq's assigned to them on rebalance. Then we should set the mask to zero, so all cpus will participate in load balancing.
Manual cherry-pick of #953