Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.14][manual] OCPBUGS-30980: irqbalance: set banned cpus list to '0' #994

Merged
merged 1 commit into from Mar 17, 2024

Conversation

yanirq
Copy link
Contributor

@yanirq yanirq commented Mar 16, 2024

Manual cherry-pick of #953

@openshift-ci openshift-ci bot requested review from ffromani and Tal-or March 16, 2024 20:48
Copy link
Contributor

openshift-ci bot commented Mar 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yanirq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2024
@openshift-cherrypick-robot

@yanirq: once the present PR merges, I will cherry-pick it on top of OCPBUGS-27227 in a new PR and assign it to you.

In response to this:

/cherry-pick OCPBUGS-27227

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yanirq
Copy link
Contributor Author

yanirq commented Mar 16, 2024

/jira cherrypick OCPBUGS-27227

@openshift-ci-robot
Copy link
Contributor

@yanirq: Jira Issue OCPBUGS-27227 has been cloned as Jira Issue OCPBUGS-30980. Will retitle bug to link to clone.
/retitle OCPBUGS-30980: irqbalance: set banned cpus list to '0'

In response to this:

/jira cherrypick OCPBUGS-27227

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title irqbalance: set banned cpus list to '0' OCPBUGS-30980: irqbalance: set banned cpus list to '0' Mar 16, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Mar 16, 2024
@openshift-ci-robot
Copy link
Contributor

@yanirq: This pull request references Jira Issue OCPBUGS-30980, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-27227 is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-27227 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0, 4.15.z
  • bug has dependents

Requesting review from QA contact:
/cc @gsr-shanks

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Manual cherry-pick of #953

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from gsr-shanks March 16, 2024 20:57
@yanirq
Copy link
Contributor Author

yanirq commented Mar 16, 2024

/uncc @gsr-shanks
/cc @SargunNarula @mrniranjan

@openshift-ci openshift-ci bot requested review from mrniranjan and SargunNarula and removed request for gsr-shanks March 16, 2024 20:59
@yanirq yanirq changed the title OCPBUGS-30980: irqbalance: set banned cpus list to '0' [release-4.14][manual] OCPBUGS-30980: irqbalance: set banned cpus list to '0' Mar 16, 2024
Empty irqbalance ban list means that irqbalance will be calculated by default.
The default will exclude all isolated and nohz_full cpus from the mask
resulting in the irq’s being balanced over the reserved cpus only,
breaking the user intent.

CPU numbers which have their corresponding bits set to one in the ban mask
will not have any irq's assigned to them on rebalance.
Then we should set the mask to zero, so all cpus will participate in load balancing.
Copy link
Contributor

openshift-ci bot commented Mar 17, 2024

@yanirq: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yanirq
Copy link
Contributor Author

yanirq commented Mar 17, 2024

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 17, 2024
@Tal-or
Copy link
Contributor

Tal-or commented Mar 17, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2024
@mrniranjan
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 17, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit d8d9739 into openshift:release-4.14 Mar 17, 2024
13 checks passed
@openshift-ci-robot
Copy link
Contributor

@yanirq: Jira Issue OCPBUGS-30980: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30980 has been moved to the MODIFIED state.

In response to this:

Manual cherry-pick of #953

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.14.0-202403191142.p0.gd8d9739.assembly.stream.el9 for distgit cluster-node-tuning-operator.
All builds following this will include this PR.

@yanirq
Copy link
Contributor Author

yanirq commented Mar 25, 2024

/cherry-pick release-4.13

@openshift-cherrypick-robot

@yanirq: #994 failed to apply on top of branch "release-4.13":

Applying: irqbalance: set banned cpus list to 0
Using index info to reconstruct a base tree...
M	test/e2e/performanceprofile/functests/1_performance/irqbalance.go
A	test/e2e/performanceprofile/testdata/render-expected-output/default/manual_machineconfig.yaml
A	test/e2e/performanceprofile/testdata/render-expected-output/no-ref/manual_machineconfig.yaml
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/performanceprofile/testdata/render-expected-output/manual_machineconfig.yaml
CONFLICT (modify/delete): test/e2e/performanceprofile/testdata/render-expected-output/default/manual_machineconfig.yaml deleted in HEAD and modified in irqbalance: set banned cpus list to 0. Version irqbalance: set banned cpus list to 0 of test/e2e/performanceprofile/testdata/render-expected-output/default/manual_machineconfig.yaml left in tree.
Auto-merging test/e2e/performanceprofile/functests/1_performance/irqbalance.go
CONFLICT (content): Merge conflict in test/e2e/performanceprofile/functests/1_performance/irqbalance.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 irqbalance: set banned cpus list to 0
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yanirq added a commit to yanirq/cluster-node-tuning-operator that referenced this pull request Mar 25, 2024
Empty irqbalance ban list means that irqbalance will be calculated by default.
The default will exclude all isolated and nohz_full cpus from the mask
resulting in the irq’s being balanced over the reserved cpus only,
breaking the user intent.

CPU numbers which have their corresponding bits set to one in the ban mask
will not have any irq's assigned to them on rebalance.
Then we should set the mask to zero, so all cpus will participate in load balancing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants