Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNF-11646: makefile:hypershift: initial make target #995

Merged
merged 1 commit into from Mar 18, 2024

Conversation

Tal-or
Copy link
Contributor

@Tal-or Tal-or commented Mar 17, 2024

Add initial make target for running e2e tests on hypershift environment.

On later PR an actual call for the e2e tests will be added.

HYPERSHIFT_MANAGEMENT_CLUSTER_KUBECONFIG and
HYPERSHIFT_HOSTED_CLUSTER_KUBECONFIG are defined
by the u/s ci and provided the kubeconfig file path for the management and hostet cluster respectively.

Add initial make target for running e2e tests on hypershift environment.

On later PR an actual call for the e2e tests will be added.

`HYPERSHIFT_MANAGEMENT_CLUSTER_KUBECONFIG` and
`HYPERSHIFT_HOSTED_CLUSTER_KUBECONFIG` are defined
by the u/s ci and provided the kubeconfig file path
for the management and hostet cluster respectively.

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 17, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 17, 2024

@Tal-or: This pull request references CNF-11646 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Add initial make target for running e2e tests on hypershift environment.

On later PR an actual call for the e2e tests will be added.

HYPERSHIFT_MANAGEMENT_CLUSTER_KUBECONFIG and
HYPERSHIFT_HOSTED_CLUSTER_KUBECONFIG are defined
by the u/s ci and provided the kubeconfig file path for the management and hostet cluster respectively.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Tal-or
Copy link
Contributor Author

Tal-or commented Mar 17, 2024

Needed for: openshift/release#49818

@yanirq
Copy link
Contributor

yanirq commented Mar 17, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2024
Copy link
Contributor

openshift-ci bot commented Mar 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Tal-or, yanirq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2024
Copy link
Contributor

openshift-ci bot commented Mar 17, 2024

@Tal-or: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ffromani
Copy link
Contributor

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Mar 18, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit f5aa533 into openshift:master Mar 18, 2024
15 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.16.0-202403180813.p0.gf5aa533.assembly.stream.el9 for distgit cluster-node-tuning-operator.
All builds following this will include this PR.

Tal-or added a commit to Tal-or/cluster-node-tuning-operator that referenced this pull request Apr 1, 2024
Add initial make target for running e2e tests on hypershift environment.

On later PR an actual call for the e2e tests will be added.

`HYPERSHIFT_MANAGEMENT_CLUSTER_KUBECONFIG` and
`HYPERSHIFT_HOSTED_CLUSTER_KUBECONFIG` are defined
by the u/s ci and provided the kubeconfig file path
for the management and hostet cluster respectively.

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants