Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNF-11646: hypershift: pao: new lane #49818

Merged
merged 1 commit into from Mar 21, 2024
Merged

CNF-11646: hypershift: pao: new lane #49818

merged 1 commit into from Mar 21, 2024

Conversation

Tal-or
Copy link
Contributor

@Tal-or Tal-or commented Mar 13, 2024 •
edited

A new lane for exercising e2e test for performance-profile operator
on hypershift cluster.

The ci exposes 3 must-to-have environment variable
which will be using later by the tests:

  1. HYPERSHIFT_MANAGEMENT_CLUSTER_KUBECONFIG - kubeconfig path of the management cluster
  2. HYPERSHIFT_MANAGEMENT_CLUSTER_NAMESPACE - namespace name on the management cluster on which the control-plane objects of the hosted-cluster reside.
  3. HYPERSHIFT_HOSTED_CLUSTER_KUBECONFIG - kubeconfig path of the hosted cluster

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 13, 2024
@Tal-or Tal-or changed the title wip: hypershift: pao CNF-11646: wip: hypershift: pao Mar 13, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 13, 2024 •
edited by openshift-ci bot

@Tal-or: This pull request references CNF-11646 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

WIP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 13, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 13, 2024
@openshift-ci openshift-ci bot requested review from enxebre and kpouget March 13, 2024 13:53
@Tal-or
Copy link
Contributor Author

Tal-or commented Mar 13, 2024

/pj-rehearse pull-ci-openshift-cluster-node-tuning-operator-master-e2e-hypershift-pao

@Tal-or Tal-or force-pushed the hypershift_for_pao_e2e_tests branch from 7abb3a9 to e154d95 Compare March 14, 2024 10:06
@Tal-or
Copy link
Contributor Author

Tal-or commented Mar 14, 2024

/pj-rehearse pull-ci-openshift-cluster-node-tuning-operator-master-e2e-hypershift-pao

1 similar comment
@Tal-or
Copy link
Contributor Author

Tal-or commented Mar 14, 2024

/pj-rehearse pull-ci-openshift-cluster-node-tuning-operator-master-e2e-hypershift-pao

@Tal-or Tal-or force-pushed the hypershift_for_pao_e2e_tests branch from e154d95 to 6f8a0f3 Compare March 14, 2024 11:06
@Tal-or
Copy link
Contributor Author

Tal-or commented Mar 14, 2024

/pj-rehearse pull-ci-openshift-cluster-node-tuning-operator-master-e2e-hypershift-pao

@Tal-or Tal-or force-pushed the hypershift_for_pao_e2e_tests branch from 6f8a0f3 to 48ec75a Compare March 14, 2024 13:31
@Tal-or
Copy link
Contributor Author

Tal-or commented Mar 14, 2024

/test ci-operator-config-metadata

@Tal-or Tal-or force-pushed the hypershift_for_pao_e2e_tests branch from 48ec75a to cd7c9f1 Compare March 14, 2024 14:07
@Tal-or
Copy link
Contributor Author

Tal-or commented Mar 14, 2024

/pj-rehearse pull-ci-openshift-cluster-node-tuning-operator-master-e2e-hypershift-pao

@Tal-or Tal-or force-pushed the hypershift_for_pao_e2e_tests branch from cd7c9f1 to f1c78a1 Compare March 14, 2024 20:23
@Tal-or
Copy link
Contributor Author

Tal-or commented Mar 14, 2024

/pj-rehearse pull-ci-openshift-cluster-node-tuning-operator-master-e2e-hypershift-pao

4 similar comments
@Tal-or
Copy link
Contributor Author

Tal-or commented Mar 14, 2024

/pj-rehearse pull-ci-openshift-cluster-node-tuning-operator-master-e2e-hypershift-pao

@Tal-or
Copy link
Contributor Author

Tal-or commented Mar 15, 2024

/pj-rehearse pull-ci-openshift-cluster-node-tuning-operator-master-e2e-hypershift-pao

@Tal-or
Copy link
Contributor Author

Tal-or commented Mar 15, 2024

/pj-rehearse pull-ci-openshift-cluster-node-tuning-operator-master-e2e-hypershift-pao

@Tal-or
Copy link
Contributor Author

Tal-or commented Mar 17, 2024

/pj-rehearse pull-ci-openshift-cluster-node-tuning-operator-master-e2e-hypershift-pao

@Tal-or Tal-or mentioned this pull request Mar 17, 2024
Merged
@Tal-or Tal-or force-pushed the hypershift_for_pao_e2e_tests branch from 9e9abdd to d31b7c6 Compare March 17, 2024 16:40
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 17, 2024 •
edited by openshift-ci bot

@Tal-or: This pull request references CNF-11646 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

A new lane for exercising e2e test for performance-profile operator
on hypershift cluster.

The ci exposes 3 must-to-have environment variable
which will be using later by the tests:

  1. HYPERSHIFT_MANAGEMENT_CLUSTER_KUBECONFIG - kubeconfig path of the management cluster
  2. HYPERSHIFT_MANAGEMENT_CLUSTER_NAMESPACE - namespace name on the management cluster on which the control-plane objects of the hosted-cluster reside.
  3. HYPERSHIFT_HOSTED_CLUSTER_KUBECONFIG - kubeconfig path of the hosted cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 17, 2024 •
edited by openshift-ci bot

@Tal-or: This pull request references CNF-11646 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

A new lane for exercising e2e test for performance-profile operator
on hypershift cluster.

The ci exposes 3 must-to-have environment variable
which will be using later by the tests:

  1. HYPERSHIFT_MANAGEMENT_CLUSTER_KUBECONFIG - kubeconfig path of the management cluster
  2. HYPERSHIFT_MANAGEMENT_CLUSTER_NAMESPACE - namespace name on the management cluster on which the control-plane objects of the hosted-cluster reside.
  3. HYPERSHIFT_HOSTED_CLUSTER_KUBECONFIG - kubeconfig path of the hosted cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Tal-or
Copy link
Contributor Author

Tal-or commented Mar 17, 2024

Depends on openshift/cluster-node-tuning-operator#995

@Tal-or
Copy link
Contributor Author

Tal-or commented Mar 17, 2024

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 17, 2024
@Tal-or Tal-or changed the title CNF-11646: wip: hypershift: pao CNF-11646: hypershift: pao Mar 17, 2024
@Tal-or Tal-or changed the title CNF-11646: hypershift: pao CNF-11646: hypershift: pao: new lane Mar 17, 2024
yanirq
yanirq reviewed Mar 17, 2024
View reviewed changes
ci-operator/step-registry/hypershift/aws/e2e/cluster/OWNERS
@@ -0,0 +1,13 @@
approvers:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is auto generated ? do we need to align it ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it's not. I copy-paste the original owners since I copied this file verbatim, but a single line I deleted

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 18, 2024
@Tal-or Tal-or force-pushed the hypershift_for_pao_e2e_tests branch from d31b7c6 to 36508c6 Compare March 18, 2024 11:15
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 18, 2024
@Tal-or
Copy link
Contributor Author

Tal-or commented Mar 18, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2024
@Tal-or
Copy link
Contributor Author

Tal-or commented Mar 18, 2024

/pj-rehearse pull-ci-openshift-cluster-node-tuning-operator-master-e2e-hypershift-pao

@Tal-or
Copy link
Contributor Author

Tal-or commented Mar 18, 2024

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 18, 2024
@yanirq
Copy link
Contributor

yanirq commented Mar 18, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2024
@Tal-or
ci: pao-hypershift lane
4edf28e 
A new lane for exercising e2e test for performance-profile operator
on hypershift cluster.

The ci exposes 3 must-to-have environment variable
which will be using later by the tests:

1. HYPERSHIFT_MANAGEMENT_CLUSTER_KUBECONFIG - kubeconfig path of the management cluster
2. HYPERSHIFT_MANAGEMENT_CLUSTER_NAMESPACE - namespace name on the management cluster on which the control-plane objects of the hosted-cluster reside.
3. HYPERSHIFT_HOSTED_CLUSTER_KUBECONFIG - kubeconfig path of the hosted cluster

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
@Tal-or Tal-or force-pushed the hypershift_for_pao_e2e_tests branch from 36508c6 to 4edf28e Compare March 19, 2024 08:56
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2024
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 19, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@Tal-or: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-node-tuning-operator-master-e2e-hypershift-pao openshift/cluster-node-tuning-operator presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@yanirq
Copy link
Contributor

yanirq commented Mar 19, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2024
@jmencak
Copy link
Contributor

jmencak commented Mar 19, 2024

/pj-rehearse pull-ci-openshift-cluster-node-tuning-operator-master-e2e-hypershift-pao

@Tal-or
Copy link
Contributor Author

Tal-or commented Mar 19, 2024

/pj-rehearse pull-ci-openshift-cluster-node-tuning-operator-master-e2e-hypershift-pao

Infra issue

@Tal-or
Copy link
Contributor Author

Tal-or commented Mar 20, 2024

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 20, 2024
@sjenning
Copy link
Contributor

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sjenning, Tal-or, yanirq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 21, 2024

@Tal-or: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 97f2c9b into openshift:master Mar 21, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanirq yanirq yanirq left review comments

@enxebre enxebre Awaiting requested review from enxebre

@kpouget kpouget Awaiting requested review from kpouget

Assignees

@yanirq yanirq

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
6 participants
@Tal-or @openshift-ci-robot @yanirq @jmencak @sjenning @openshift-merge-robot