waits for extension-apiserver-authentication before rolling out a new version #319
Conversation
|
@p0lyn0mial: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
size/S
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, p0lyn0mial The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
| @@ -142,6 +145,21 @@ func (c OpenShiftAPIServerOperator) sync() error { | |||
| return nil | |||
| } | |||
|
|
|||
| // block until extension-apiserver-authentication configmap is available | |||
| // see https://bugzilla.redhat.com/show_bug.cgi?id=1795163#c19 to check why we have to wait for it | |||
| // in the future we need to change upstream code to be more dynamic | |||
There was a problem hiding this comment.
// block until extension-apiserver-authentication configmap is available to avoid
// that openshift-apiserver starts up with request header setting (which are not dynamically reloaded).
| if !c.haveObservedExtensionConfigMap { | ||
| _, err = c.kubeClient.CoreV1().ConfigMaps(metav1.NamespaceSystem).Get("extension-apiserver-authentication", metav1.GetOptions{}) | ||
| if apierrors.IsNotFound(err) { | ||
| klog.Infof("Waiting for %q configmap in %q namespace to be available", "extension-apiserver-authentication", metav1.NamespaceSystem) |
There was a problem hiding this comment.
how do we wait? Are we triggered by that configmap here?
|
/close as this is not entirely what we need. |
|
@p0lyn0mial: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.