Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve e2e tests #419

Merged
merged 3 commits into from Nov 30, 2020
Merged

improve e2e tests #419

merged 3 commits into from Nov 30, 2020

Conversation

p0lyn0mial
Copy link
Contributor

especially that we also run the encryption tests which require a few rollout and migration time.

@p0lyn0mial
Copy link
Contributor Author

/assign @stlaz

@p0lyn0mial
Copy link
Contributor Author

should unblock - #417

@stlaz
Copy link
Member

stlaz commented Nov 26, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2020
@p0lyn0mial
Copy link
Contributor Author

we observed frequent timeouts (10m) in #417.
the must-gather suggest that encryption was successful. we suspect that the default timeout is too low.

@p0lyn0mial
Copy link
Contributor Author

/assign @sttts

@sttts
Copy link
Contributor

sttts commented Nov 26, 2020

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2020
@p0lyn0mial
Copy link
Contributor Author

/test e2e-aws-operator-encryption

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2020
@p0lyn0mial p0lyn0mial changed the title extend the default timeout from 10 min to 20 when running e2e tests extend the default timeout from 10 min to 1h when running e2e tests Nov 26, 2020
@p0lyn0mial
Copy link
Contributor Author

/test e2e-aws-operator-encryption

@p0lyn0mial
Copy link
Contributor Author

it looks like TestRedeployOnConfigChange (https://github.com/openshift/cluster-openshift-apiserver-operator/blob/master/test/e2e/operator_test.go#L34) test changes a config map that triggers a new revision and doesn't wait until all pods are installed. Not ideal for the encryption tests that need to wait longer.

@p0lyn0mial
Copy link
Contributor Author

it looks like TestRedeployOnConfigChange (https://github.com/openshift/cluster-openshift-apiserver-operator/blob/master/test/e2e/operator_test.go#L34) test changes a config map that triggers a new revision and doesn't wait until all pods are installed. Not ideal for the encryption tests that need to wait longer.

the second commit addresses that, should be moved to library-go

@p0lyn0mial p0lyn0mial changed the title extend the default timeout from 10 min to 1h when running e2e tests improve e2e tests Nov 26, 2020
@p0lyn0mial
Copy link
Contributor Author

/test e2e-aws-operator-encryption
/retest

@p0lyn0mial
Copy link
Contributor Author

/retest

@p0lyn0mial
extend the default timeout from 10 min to 1h when running e2e tests
ce0dcb0 
especially that we also run the encryption tests which require a few rollout and migration time.
@p0lyn0mial
Copy link
Contributor Author

/test e2e-aws-operator

@p0lyn0mial
Copy link
Contributor Author

requires openshift/library-go#949

@sttts
Copy link
Contributor

sttts commented Nov 30, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, stlaz, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit af6e44e into openshift:master Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@sttts sttts Awaiting requested review from sttts

Assignees

@stlaz stlaz

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@p0lyn0mial @stlaz @sttts @openshift-ci-robot @openshift-merge-robot