Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: provides WaitForAPIServerToStabilizeOnTheSameRevision waits until all API Servers are running at the same revision #949

Merged

Conversation

p0lyn0mial
Copy link
Contributor

Provides a convenience function for ensuring that APIs have converged to the same revision. The function is meant to be used in tests that require rolling out a new version (i.e. config change).

The API Servers must stay on the same revision for at least waitForAPIRevisionSuccessThreshold * waitForAPIRevisionSuccessInterval.
Mainly because of the difference between the propagation time of triggering a new release and the actual roll-out.

Observations:

  • rolling out a new version is not instant you need to account for a propagation time (~1/2 minutes)
  • for some API servers (KAS) rolling out a new version can take ~10 minutes

@p0lyn0mial
Copy link
Contributor Author

this function was introduced in openshift/cluster-kube-apiserver-operator#870

moving here so it can be reused

@p0lyn0mial
Copy link
Contributor Author

/assign @sttts

@p0lyn0mial
Copy link
Contributor Author

/retest

@p0lyn0mial p0lyn0mial force-pushed the wait-for-api-to-converge branch 2 times, most recently from a36e643 to e88c09c Compare November 30, 2020 09:06
…til all API Servers are running at the same revision.
@sttts
Copy link
Contributor

sttts commented Nov 30, 2020

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2020
@openshift-merge-robot openshift-merge-robot merged commit 8a855b6 into openshift:master Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants