expose pod information to oas container via env variables #440

p0lyn0mial · 2021-03-30T11:07:13Z

the pod name and the namespace are used by the termination code to properly record events.

before the change the termination events were recorded to the default namespace and weren't associated with any pod.
after the change, the termination evens are recorded in the openshift-apiserver namespace and are bound to oas pods.

the pod name and the namespace are used by the termination code to properly record events. before the change the termination events were recorded to the default namespace and weren't associated with any pod. after the change, the termination evens are recorded in the openshift-apiserver namespace and are bound to oas pods.

p0lyn0mial · 2021-03-30T11:07:30Z

/assign @smarterclayton @sttts

p0lyn0mial · 2021-03-30T11:07:58Z

I'm going to check oauth-apiserver as well.

p0lyn0mial · 2021-03-30T13:18:06Z

for the record TerminationMinimalShutdownDuration is set to 0 for both oas and oauth-apiserver. This seems to be ok since we already have terminationGracePeriodSeconds (70s) set.

p0lyn0mial · 2021-03-30T14:30:21Z

for the record TerminationMinimalShutdownDuration is set to 0 for both oas and oauth-apiserver. This seems to be ok since we already have terminationGracePeriodSeconds (70s) set.

this is wrong! terminationGracePeriodSeconds is how long kubelet waits before it terminates oas. It doesn't guarantee that it will always wait for that long.

That means our aggregated APIs are not terminated gracefully.
According to Clayton, things on pod / service network need to wait 15-20s. That means we should set shutdown-delay-duration at least to 15s. Thanks!

p0lyn0mial · 2021-03-30T14:35:40Z

I'm going to open follow-up PRs for shutdown-delay-duration next week, after my holidays.

sttts · 2021-04-06T12:29:23Z

/lgtm
/approve

openshift-ci-robot · 2021-04-06T12:29:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sttts]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-04-06T12:36:46Z

/retest