OCPBUGS-16554: update dependencies to get rid of goproxy #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* openshift/api@a025b2b3: OCPBUGS-11393: Fix incorrect API usage documentation for insecureEdgeTerminationPolicy * openshift/api@edd0a472: RFE-3765 - Allow Ingress to Modify the HAProxy Log Length when using a Sidecar * openshift/api@a9141ebe: Update 0000_50_ingress-operator_00-ingresscontroller.crd.yaml * openshift/api@3a1fb8a6: Update types_ingress.go * openshift/api@52113245: Update 0000_50_ingress-operator_00-ingresscontroller.crd.yaml * openshift/api@cd55a34f: Update zz_generated.swagger_doc_generated.go * openshift/api@040197f2: RFE-3765 - Including a message about the range of values for maxLength when using a Container for log capture from route * openshift/api@41f72c6f: RFE-3765 - Including a message about the range of values for maxLength when send the router logs for an external syslog * openshift/api@d8a2c835: RFE-3765 - Including a message about the range of values for maxLength in CRD deffinition when collecting router logs * openshift/api@cb506327: RFE-3765 - Including a dot at the end of description of log maxLenght in CRD definition. * openshift/api@d0a12d8c: Revert operator/v1/zz_generated.swagger_doc_generated.go * openshift/api@15fe7cbc: RFE-3765 - Fixing file operator/v1/0000_50_ingress-operator_00-ingresscontroller.crd.yaml for automated test * openshift/api@06d737da: RFE-3765 - Adding files operator/v1/zz_generated.swagger_doc_generated.go, openapi/openapi.json, openapi/generated_opena * openshift/api@c6baf1fb: Add InsecureEdgeTerminationPolicy kubebuilder CEL validation * openshift/api@fca46d24: Add maxLogFiles config for OVN-K Audit Logging * openshift/api@0e0a453c: OCPBUGS-6829: Add protocolStrategy for upstreams in dnses.operator.openshift.io * openshift/api@5b630ed5: STOR-1308: Add Secrets Store CSI driver provider * openshift/api@c28088cd: Merge branch 'openshift:master' into rfe-3765 * openshift/api@f0400a36: RFE-3765 - Modifying the maxLength parameter message for Container and Syslog * openshift/api@3dd9c2fa: RFE-3765 - Modifying the maxLength parameter message for Container and Syslog - update openapi.json * openshift/api@3778e7a4: [CNF-5643]add machine-api capability * openshift/api@5ae9b829: TechPreviewNoUpgrade: enable MaxUnavailableStatefulSet * openshift/api@35cd9b44: OCPBUGS-13914: allow removal of vsphereStorageDriver field in 4.14 * openshift/api@8193b054: Add feature gate for AWS Private Hosted Zone support * openshift/api@357f6ba1: Add config knob for enabling ip forwarding * openshift/api@83c90e8f: Add `SigstoreImageVerification` feature gate * openshift/api@2f2626ed: Add Evented Pleg as a Tech-Preview feature in the Openshift * openshift/api@2f2d4639: Rework IP Forwarding config * openshift/api@e32946b9: Merge branch 'openshift:master' into rfe-3765 * openshift/api@dcd3d997: Modifying the help message of MaxLength in Syslog and Container. Modifying the variable type of MaxLength to int32 in Sy * openshift/api@1723e46b: CFE-685 : Add TechPreviewNoUpgrade featureGate for GCP Labels and Tags support * openshift/api@815017c8: DNS: Add awsPrivateHostedZoneRole * openshift/api@c85edfc9: RFE-3765: Reverting modifications on SyslogLoggingDestinationParameters parameters * openshift/api@6939ac5e: Merge branch 'openshift:master' into rfe-3765 * openshift/api@e1b4d36d: Add AlibabaPlatform feature gate to TechPreviewNoUpgrade * openshift/api@c6506429: make the default DNS only install for default to avoid conflicts * openshift/api@d5c3a321: DNS: Fix hostedZoneRole regex Pattern * openshift/api@dd7c8c69: Disable EventedPLEG featuregate in techpreview * openshift/api@66609278: RFE-3765: Updating the MaxLength message for Container and Syslog options. * openshift/api@f8e1a6d4: Merge branch 'openshift:master' into rfe-3765 * openshift/api@e21789b2: Merge branch 'rfe-3765' of github.com:dafsjr/openshift-api into rfe-3765 * openshift/api@fe46f415: OSASINFRA-3061 - OpenStackFailureDomain for CPMS * openshift/api@6bf781dd: OPNET-263: Enable CloudDualStackNodeIPs feature gate * openshift/api@94b679b4: prerelease-lifecycle-gen: generated deprecation of APIs * openshift/api@f4512c33: Deprecate DeploymentConfigs in 4.14 without their removal * openshift/api@2e77e761: Merge branch 'openshift:master' into rfe-3765 * openshift/api@9a502365: RFE-3765: Modifying the default and optional parameters for MaxLength * openshift/api@fa07e3af: DeploymentConfigs deprecation in API reference docs * openshift/api@1974bb36: OCPCLOUD-2010: Add CloudControllerManagerStatus to the `External` platform status * openshift/api@3361940d: Add field validations and tests * openshift/api@99f7e5b4: Set CloudControllerManagerStatus behind TechPreviewNoUpgrade feature set * openshift/api@db0028c7: update CEL to be more accurate * openshift/library-go@23868674: Refactor version sync to standalone method * openshift/library-go@2e411423: Add a flag to StatusController to remove unknown versions * openshift/library-go@2e0cf33a: remove the old featuresets flag that can conflict with manifests * openshift/library-go@449a71a9: Make sure the directory path is included in rendered manifest paths * openshift/library-go@01526ee8: go.mod: upgrade distribution/distribution to v3 * openshift/library-go@5f6dba98: vendor: upgrade distribution/distribution files * openshift/library-go@cc39b81d: pkg/image: update distribution/distribution import paths to v3 * openshift/library-go@23e55593: OWNERS: add myself and remove clayton * openshift/library-go@19a42d2b: staticpod installer: set the manifests directory permissions to 0600 * openshift/library-go@ede37b94: pkg/controller/factory: report fast resync interval ony when > 0 and < 60 * openshift/library-go@83209ffd: factory/base_controller: properly synchronize runPeriodicalResync function * openshift/library-go@744140e4: library-go: fix flakiness of TestGetName * openshift/library-go@d2f7a752: library-go: GetName must not return value starting from the dash * openshift/library-go@b536bb6f: OCPCLOUD-2010: Add external platform type support in IsCloudProviderExternal * openshift/library-go@7416df83: Add OWNERS file for cloudprovider package * openshift/library-go@e7e7b223: OCPBUGS-14876: library-go: `ApplyStorageClass()` must not ignore `ResourceVersion` of `required` arg * openshift/library-go@75c7d51f: controller/apiservice: allow to disable/delete an API service resources * openshift/library-go@07eb73d0: tokenrequest: add support for authorization code flow with proof key for code exchange * openshift/library-go@6de88d61: installerpod: change config map based files mode to 0600 * openshift/library-go@0cf7e72a: pkg/manifest: Add Manifest.String() method * openshift/library-go@a319832b: add helpers to make it easy to include openshift featuregates * openshift/library-go@7bf38d4d: Allow CredentialsRequestController to work in STS mode * openshift/library-go@98d6c801: bump(*): bump sigs.k8s.io/kube-storage-version-migrator
mfojtik
commented
Jul 24, 2023
| @@ -180,7 +180,9 @@ func RunOperator(ctx context.Context, controllerConfig *controllercmd.Controller | |||
| controllerConfig.EventRecorder, | |||
| ).WithAPIServiceController( | |||
| "openshift-apiserver", | |||
| func() ([]*apiregistrationv1.APIService, error) { return apiServices(), nil }, | |||
| func() (enabled []*apiregistrationv1.APIService, disabled []*apiregistrationv1.APIService, err error) { | |||
There was a problem hiding this comment.
@ingvagabund pleas review
There was a problem hiding this comment.
Done in 96e3280. How fast this PR needs to merge?
There was a problem hiding this comment.
I'll rebase then. feel free to go ahead.
openshift-ci
bot
added
the
approved
mfojtik
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@mfojtik: This pull request references Jira Issue OCPBUGS-16554, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
|
@mfojtik: This pull request references Jira Issue OCPBUGS-16554, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
p0lyn0mial
reviewed
Jul 24, 2023
| @@ -180,7 +180,9 @@ func RunOperator(ctx context.Context, controllerConfig *controllercmd.Controller | |||
| controllerConfig.EventRecorder, | |||
| ).WithAPIServiceController( | |||
| "openshift-apiserver", | |||
| func() ([]*apiregistrationv1.APIService, error) { return apiServices(), nil }, | |||
| func() (enabled []*apiregistrationv1.APIService, disabled []*apiregistrationv1.APIService, err error) { | |||
| return apiServices(), nil, nil | |||
There was a problem hiding this comment.
yes, allServices should be enabled, none disabled until @ingvagabund merges his feature.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik, p0lyn0mial The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@mfojtik: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@mfojtik: Jira Issue OCPBUGS-16554: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-16554 has been moved to the MODIFIED state. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.