Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump(*) #114

Merged
merged 1 commit into from
Aug 6, 2019
Merged

bump(*) #114

merged 1 commit into from
Aug 6, 2019

Conversation

Fedosin
Copy link
Contributor

@Fedosin Fedosin commented Aug 5, 2019

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 5, 2019
@Fedosin
Copy link
Contributor Author

Fedosin commented Aug 5, 2019

/retest

@tnozicka
Copy link
Contributor

tnozicka commented Aug 5, 2019

convention for commit messages on vendor changes is Bump (*) since you bump it all anyways

@Fedosin Fedosin changed the title vendor: bump library-go for updated cloudprovider observer bump(*) Aug 5, 2019
@tnozicka
Copy link
Contributor

tnozicka commented Aug 6, 2019

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fedosin, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2019
@openshift-merge-robot openshift-merge-robot merged commit 1e84f57 into openshift:master Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants