Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logs for quota namespace syncing with verbosity level 2 #119

Merged

Conversation

ardaguclu
Copy link
Member

@ardaguclu ardaguclu commented Jul 10, 2023

There is a flaky test failure which is tracked in https://issues.redhat.com/browse/OCPBUGS-15568 in regards to
cluster quota. Up to this point, investigations(openshift/origin#28026, openshift/origin#28032) proved that quota reconciliation does not update
ClusterResourceQuotaStatus with the matching namespaces accordingly(as seen in the example failed job) (actually it does not update ClusterResourceQuotaStatus at all).

This PR adds more logs to better investigate the problem. Since these logs are being added with verbosity level 2, there might not be needed to revert these logs, once investigation is completed, unless it generates noise in CI jobs.

@openshift-ci openshift-ci bot requested review from atiratree and soltysh July 10, 2023 12:14
@ardaguclu
Copy link
Member Author

/cc @ingvagabund
could you PTAL?. Thanks.

@openshift-ci openshift-ci bot requested a review from ingvagabund July 10, 2023 12:15
@ardaguclu ardaguclu changed the title Add logs for quota namespace syncing with verbosity level 2 WIP: Add logs for quota namespace syncing with verbosity level 2 Jul 10, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 10, 2023
@ardaguclu ardaguclu changed the title WIP: Add logs for quota namespace syncing with verbosity level 2 Add logs for quota namespace syncing with verbosity level 2 Jul 10, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 10, 2023
@ardaguclu
Copy link
Member Author

@ingvagabund as we talked earlier, I have added more logs from your commit ingvagabund@c6a91c6

@ingvagabund
Copy link
Member

Thx! Let's see how many new log lines the CI will produce.

@ingvagabund
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 11, 2023

@ardaguclu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, ingvagabund, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2023
@openshift-merge-robot openshift-merge-robot merged commit 3b6a995 into openshift:master Jul 11, 2023
@ardaguclu ardaguclu deleted the add-logs-to-track-quota branch July 11, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants