New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-15568: Handle error if caches are not synced instead silently exit #121
OCPBUGS-15568: Handle error if caches are not synced instead silently exit #121
Conversation
Currently, `clusterQuotaReconciliationController` silently exist if caches are not synced in time. That causes other controllers continue working even though workers are not working. This PR makes cache sync timeout errors visible as well as adding move logs.
@ardaguclu: This pull request references Jira Issue OCPBUGS-15568, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/uncc @soltysh @stlaz |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu, ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ardaguclu: This pull request references Jira Issue OCPBUGS-15568, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ardaguclu: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@ardaguclu: Jira Issue OCPBUGS-15568: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-15568 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Currently,
clusterQuotaReconciliationController
silently exits if caches are not synced in time. That causes other controllers continue working even though workers are not working.This PR makes cache sync timeout errors visible as well as adding more logs.
More context about the problem;
In this job, there is
calculating items for quota overall-e2e-test-crq-gfx7x with namespaces [{e2e-test-crq-plxxl false}]
log(which proves that namespace lister is working). However, there is not any log indicating that this is handled by workers in here