Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-15568: Handle error if caches are not synced instead silently exit #121

Merged

Conversation

ardaguclu
Copy link
Member

@ardaguclu ardaguclu commented Jul 17, 2023

Currently, clusterQuotaReconciliationController silently exits if caches are not synced in time. That causes other controllers continue working even though workers are not working.

This PR makes cache sync timeout errors visible as well as adding more logs.

More context about the problem;

In this job, there is calculating items for quota overall-e2e-test-crq-gfx7x with namespaces [{e2e-test-crq-plxxl false}] log(which proves that namespace lister is working). However, there is not any log indicating that this is handled by workers in here

Currently, `clusterQuotaReconciliationController` silently exist if
caches are not synced in time. That causes other controllers continue working
even though workers are not working.

This PR makes cache sync timeout errors visible as well as adding move logs.
@openshift-ci openshift-ci bot requested review from soltysh and stlaz July 17, 2023 09:56
@ardaguclu ardaguclu changed the title Handle error if caches are not synced instead silently exit OCPBUGS-15568: Handle error if caches are not synced instead silently exit Jul 17, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jul 17, 2023
@openshift-ci-robot
Copy link
Contributor

@ardaguclu: This pull request references Jira Issue OCPBUGS-15568, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhouying7780

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Currently, clusterQuotaReconciliationController silently exist if caches are not synced in time. That causes other controllers continue working even though workers are not working.

This PR makes cache sync timeout errors visible as well as adding more logs.

More context about the problem;

In this job, there is calculating items for quota overall-e2e-test-crq-gfx7x with namespaces [{e2e-test-crq-plxxl false}] log(which proves that namespace lister is working). However, there is not any log indicating that this is handled by workers in here

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from zhouying7780 July 17, 2023 09:57
@ardaguclu
Copy link
Member Author

/uncc @soltysh @stlaz
/cc @ingvagabund @atiratree

@openshift-ci openshift-ci bot requested review from atiratree and ingvagabund and removed request for soltysh and stlaz July 17, 2023 09:57
@ingvagabund
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2023
@openshift-ci-robot
Copy link
Contributor

@ardaguclu: This pull request references Jira Issue OCPBUGS-15568, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhouying7780

In response to this:

Currently, clusterQuotaReconciliationController silently exits if caches are not synced in time. That causes other controllers continue working even though workers are not working.

This PR makes cache sync timeout errors visible as well as adding more logs.

More context about the problem;

In this job, there is calculating items for quota overall-e2e-test-crq-gfx7x with namespaces [{e2e-test-crq-plxxl false}] log(which proves that namespace lister is working). However, there is not any log indicating that this is handled by workers in here

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 17, 2023

@ardaguclu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 922f9ad into openshift:master Jul 17, 2023
7 checks passed
@openshift-ci-robot
Copy link
Contributor

@ardaguclu: Jira Issue OCPBUGS-15568: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-15568 has not been moved to the MODIFIED state.

In response to this:

Currently, clusterQuotaReconciliationController silently exits if caches are not synced in time. That causes other controllers continue working even though workers are not working.

This PR makes cache sync timeout errors visible as well as adding more logs.

More context about the problem;

In this job, there is calculating items for quota overall-e2e-test-crq-gfx7x with namespaces [{e2e-test-crq-plxxl false}] log(which proves that namespace lister is working). However, there is not any log indicating that this is handled by workers in here

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants