Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-15726: UPSTREAM: 118879: make apiservices.apiregistration.k8s.io discoverabl… #1630

Merged
merged 1 commit into from Aug 2, 2023
Merged

OCPBUGS-15726: UPSTREAM: 118879: make apiservices.apiregistration.k8s.io discoverabl… #1630

merged 1 commit into from Aug 2, 2023

Conversation

ardaguclu
Copy link
Member

@openshift-ci-robot openshift-ci-robot added backports/validated-commits Indicates that all commits come to merged upstream PRs. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jul 10, 2023
@openshift-ci-robot
Copy link

@ardaguclu: This pull request references Jira Issue OCPBUGS-15568, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhouying7780

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Carrying kubernetes#118879

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from zhouying7780 July 10, 2023 10:33
@openshift-ci-robot
Copy link

@ardaguclu: the contents of this pull request could be automatically validated.

The following commits are valid:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot requested review from mfojtik and soltysh July 10, 2023 10:35
@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Jul 10, 2023
soltysh
soltysh approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 10, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD af29f64 and 2 for PR HEAD 28714de in total

@ardaguclu
Copy link
Member Author

/retest

@ardaguclu
Copy link
Member Author

/test e2e-aws-ovn-fips

@ardaguclu
Copy link
Member Author

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 0abcd84 and 1 for PR HEAD 28714de in total

@ardaguclu
Copy link
Member Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 11, 2023
@ardaguclu
Copy link
Member Author

/retest-required

@ardaguclu
Copy link
Member Author

This aws-ovn-fips job https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_kubernetes/1629/pull-ci-openshift-kubernetes-master-e2e-aws-ovn-fips/1679760031450402816 has passed to testing stage.
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 14, 2023
@ardaguclu
Copy link
Member Author

/retest-required

1 similar comment
@ardaguclu
Copy link
Member Author

/retest-required

@ardaguclu
Copy link
Member Author

unrelated;
/retest-required

@ardaguclu
Copy link
Member Author

/retest-required

@ardaguclu ardaguclu changed the title OCPBUGS-15568: UPSTREAM: 118879: make apiservices.apiregistration.k8s.io discoverabl… OCPBUGS-15726: UPSTREAM: 118879: make apiservices.apiregistration.k8s.io discoverabl… Jul 14, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. and removed jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jul 14, 2023
@atiratree
Copy link
Member

verify should be passing: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_kubernetes/1646/pull-ci-openshift-kubernetes-master-verify/1683581031002673152
/test verify

@ardaguclu ardaguclu force-pushed the apiregistration-openapiv3-fix branch from 28714de to b3a3912 Compare July 25, 2023 14:12
@openshift-ci-robot
Copy link

@ardaguclu: the contents of this pull request could be automatically validated.

The following commits are valid:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2023
@atiratree
Copy link
Member

/test verify
/test unit

@atiratree
Copy link
Member

atiratree commented Jul 25, 2023 •
edited

verify is failing because we are using a container image with old golang version (1.20.3), but kubernetes requires at least version 1.20.5: kubernetes#118553, https://github.com/openshift/kubernetes/blob/master/.go-version

this causes the difference in go.mod which fails our verify-vendor.sh:
kubernetes@e0a2a6e#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63

@atiratree
Copy link
Member

/test unit

@ardaguclu
Copy link
Member Author

/test e2e-aws-ovn-cgroupsv2
/test e2e-aws-ovn-fips

@bertinatto
Copy link
Member

/test unit

@ardaguclu
Copy link
Member Author

/test e2e-aws-ovn-cgroupsv2
/test e2e-aws-ovn-fips
/test verify

@ardaguclu
Copy link
Member Author

/test e2e-aws-ovn-cgroupsv2

@ardaguclu
Copy link
Member Author

/test verify

1 similar comment
@ardaguclu
Copy link
Member Author

/test verify

@ardaguclu
Copy link
Member Author

@atiratree could you please tag this?. Thanks.

@atiratree
Copy link
Member

verify should pass after #1645 merges
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, atiratree, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ardaguclu
Copy link
Member Author

it is too early for retesting but let's try once;
/test verify

@ardaguclu
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 2, 2023

@ardaguclu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit ba18255 into openshift:master Aug 2, 2023
18 checks passed
@openshift-ci-robot
Copy link

@ardaguclu: Jira Issue OCPBUGS-15726: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-15726 has been moved to the MODIFIED state.

In response to this:

Carrying kubernetes#118879

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ardaguclu ardaguclu deleted the apiregistration-openapiv3-fix branch August 2, 2023 15:26
This was referenced Aug 7, 2023
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@zhouying7780 zhouying7780 Awaiting requested review from zhouying7780

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@soltysh soltysh

@atiratree atiratree

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ardaguclu @openshift-ci-robot @ingvagabund @atiratree @bertinatto @soltysh @openshift-merge-robot