Switch to go.mod and bump to k8s 1.17.1 #16
Conversation
| k8s.io/kubernetes v1.17.1 | ||
| ) | ||
|
|
||
| replace ( |
There was a problem hiding this comment.
later try to remove replaces. My guess is that k/k is requiring several of these replaces. If so, just comment to that effect.
There was a problem hiding this comment.
I already tried, the ones required are the top 4, although I might try getting rid of glog now for sure, probably ginkgo too the other two has to stay. The k8s needs to be there since go.mod can't parse them out from k/k since it points to staging 😞
|
/approve |
|
Fixed deps, let's wait for the tests now. |
openshift-ci-robot
added
the
size/XXL
openshift-ci-robot
added
the
approved
|
/retest |
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Picks some of the changes from #10 but I started with go.mod and bump first. More will follow up to land something along the lines like #10.
/assign @deads2k