Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.11] OCPBUGS-5787: clusterquotareconciliation: do not sync quota monitor cache with no monitors registered #96

Merged
merged 1 commit into from Jan 16, 2023
Merged

[release-4.11] OCPBUGS-5787: clusterquotareconciliation: do not sync quota monitor cache with no monitors registered #96

merged 1 commit into from Jan 16, 2023

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #94

/assign ingvagabund

@ingvagabund
clusterquotareconciliation: do not sync quota monitor cache with no m…
abfcd76 
…onitors registered

Empty list of resources is a sign of incorrectness in the cluster.
Either the kube-apiserver incorrectly returns an empty list with no error.
Or, the client-code responsible for processing response from the discovery
is incorrectly interpretting the server error.

If the list of resources is zero, all current monitors are cleared and removed.
Followed by invoking c.quotaMonitor.IsSynced which is always false when there's
no monitor running. In which case cache.WaitForCacheSync never returns
and loops indefinitely. Never resyncing the resources. Thus, none of the resources
mentioned on any ClusterResourceQuota's status are recomputed since there's no
resource monitor to provide current resource usage.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 12, 2023
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-723 has been cloned as Jira Issue OCPBUGS-5787. Retitling PR to link against new bug.
/retitle [release-4.11] OCPBUGS-5787: clusterquotareconciliation: do not sync quota monitor cache with no monitors registered

In response to this:

This is an automated cherry-pick of #94

/assign ingvagabund

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.11] OCPBUGS-723: clusterquotareconciliation: do not sync quota monitor cache with no monitors registered [release-4.11] OCPBUGS-5787: clusterquotareconciliation: do not sync quota monitor cache with no monitors registered Jan 12, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 12, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-5787, which is invalid:

  • expected dependent Jira Issue OCPBUGS-723 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is MODIFIED instead
  • expected dependent Jira Issue OCPBUGS-723 to target a version in 4.12.0, but it targets "4.13.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #94

/assign ingvagabund

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2023

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.11] OCPBUGS-5787: clusterquotareconciliation: do not sync quota monitor cache with no monitors registered

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from soltysh and stlaz January 12, 2023 15:28
soltysh
soltysh approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2023
@ingvagabund
Copy link
Member

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 12, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2023

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kasturinarra
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 16, 2023
@soltysh
Copy link
Member

soltysh commented Jan 16, 2023

Manually overriding valid-bug label, we have #95 already in the queue, but due to current timing it will merge a bit later, and we need to expedite the delivery of 4.11 and 4.10

@soltysh soltysh added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 16, 2023
@openshift-merge-robot openshift-merge-robot merged commit 5651181 into openshift:release-4.11 Jan 16, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-5787 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #94

/assign ingvagabund

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@stlaz stlaz Awaiting requested review from stlaz

Assignees

@soltysh soltysh

@ingvagabund ingvagabund

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@openshift-cherrypick-robot @openshift-ci-robot @ingvagabund @kasturinarra @soltysh @openshift-merge-robot