Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.11] OCPBUGS-5787: clusterquotareconciliation: do not sync quota monitor cache with no monitors registered #96

Commits on Jan 12, 2023

  1. clusterquotareconciliation: do not sync quota monitor cache with no m…

    …onitors registered
    
    Empty list of resources is a sign of incorrectness in the cluster.
    Either the kube-apiserver incorrectly returns an empty list with no error.
    Or, the client-code responsible for processing response from the discovery
    is incorrectly interpretting the server error.
    
    If the list of resources is zero, all current monitors are cleared and removed.
    Followed by invoking c.quotaMonitor.IsSynced which is always false when there's
    no monitor running. In which case cache.WaitForCacheSync never returns
    and loops indefinitely. Never resyncing the resources. Thus, none of the resources
    mentioned on any ClusterResourceQuota's status are recomputed since there's no
    resource monitor to provide current resource usage.
    ingvagabund authored and openshift-cherrypick-robot committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    abfcd76 View commit details
    Browse the repository at this point in the history