Bug 1804763: add imagestream for oauthproxy image #228
Conversation
openshift-ci-robot
added
size/S
|
@gabemontero do we have any sort of test coverage for these imagestreams? |
openshift-ci-robot
added
the
approved
|
/hold |
openshift-ci-robot
added
do-not-merge/hold
|
/cc @sttts I don't see problem shipping this via image stream as people can use it today anyway (and they do). ImageStream only makes it available for disconnected users. |
|
/lgtm Will wait for @sttts to unhold. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, mfojtik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Not as part of image-eco @bparees I've tangentially seen some of them used in CI in other contexts of course (must-gather for artifact collection ... don't recall if that uses cli or not). |
|
/test e2e-aws-image-ecosystem |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
bparees
changed the title
|
/bugzilla refresh |
|
/cherrypick release-4.4 |
|
@bparees: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
@bparees: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest As discussed on Slack with @bparees @jwforres @smarterclayton this only makes the image stream available to components outside of OpenShift core. This does not imply any support or any future compatibility. Flags will change. /hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@bparees: All pull requests linked via external trackers have merged. Bugzilla bug 1804763 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
@bparees: All pull requests linked via external trackers have merged. Bugzilla bug 1804763 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@bparees: failed to push cherry-picked changes in GitHub: pushing failed, output: "To https://github.com/openshift-cherrypick-robot/cluster-samples-operator\n ! [remote rejected] cherry-pick-228-to-release-4.4 -> cherry-pick-228-to-release-4.4 (cannot lock ref 'refs/heads/cherry-pick-228-to-release-4.4': reference already exists)\nerror: failed to push some refs to 'https://openshift-cherrypick-robot:CENSORED@github.com/openshift-cherrypick-robot/cluster-samples-operator'\n", error: exit status 1 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@bparees: new pull request created: #229 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@bparees: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/cherrypick release-4.2 |
|
@bparees: failed to push cherry-picked changes in GitHub: pushing failed, output: "To https://github.com/openshift-cherrypick-robot/cluster-samples-operator\n ! [remote rejected] cherry-pick-228-to-release-4.2 -> cherry-pick-228-to-release-4.2 (cannot lock ref 'refs/heads/cherry-pick-228-to-release-4.2': reference already exists)\nerror: failed to push some refs to 'https://openshift-cherrypick-robot:CENSORED@github.com/openshift-cherrypick-robot/cluster-samples-operator'\n", error: exit status 1 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@bparees: new pull request created: #231 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.