Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.4] Bug 1871832: initial create errors should map to SamplesExists instead of ImageChangesInProgress #315

Merged
merged 1 commit into from
Sep 11, 2020
Merged

[release-4.4] Bug 1871832: initial create errors should map to SamplesExists instead of ImageChangesInProgress #315

merged 1 commit into from
Sep 11, 2020

Conversation

gabemontero
Copy link
Contributor

@gabemontero gabemontero commented Aug 24, 2020 •
edited
Loading

This PR is needed to replace #314 from the cherrypick bot because of differences in behavior between 4.4 and 4.5/4.6

We copy creds and track that condition in 4.4, but no longer do so in 4.5/4.6, so the unit tests in 4.4 need an additional step of adding the necessary security conditions via a call to processCred to bypass that short circuit so we can get to validating the template / imagestream upsert error logic.

See detailed triage in #314 (comment)

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Aug 24, 2020
@openshift-ci-robot
Copy link
Contributor

@gabemontero: This pull request references Bugzilla bug 1871832, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.4.z) matches configured target release for branch (4.4.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1857201 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1857201 targets the "4.5.z" release, which is one of the valid target releases: 4.5.0, 4.5.z
  • bug has dependents

In response to this:

[release-4.4] [release-4.5] Bug 1871832: initial create errors should map to SamplesExists instead of ImageChangesInProgress

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 24, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2020
@gabemontero gabemontero mentioned this pull request Aug 24, 2020
Closed
@openshift-ci-robot
Copy link
Contributor

@gabemontero: This pull request references Bugzilla bug 1871832, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.4.z) matches configured target release for branch (4.4.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1857201 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1857201 targets the "4.5.z" release, which is one of the valid target releases: 4.5.0, 4.5.z
  • bug has dependents

In response to this:

[release-4.4] [release-4.5] Bug 1871832: initial create errors should map to SamplesExists instead of ImageChangesInProgress

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero
Copy link
Contributor Author

throttling on the image-eco run ... test container could not get launched

@gabemontero
Copy link
Contributor Author

/retest

@gabemontero
Copy link
Contributor Author

lease issue on image eco

/retest

@gabemontero
Copy link
Contributor Author

ok all tests green on this manual cherrypick

/assign @adambkaplan

@openshift-ci-robot
Copy link
Contributor

@gabemontero: This pull request references Bugzilla bug 1871832, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.4.z) matches configured target release for branch (4.4.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1857201 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1857201 targets the "4.5.z" release, which is one of the valid target releases: 4.5.0, 4.5.z
  • bug has dependents

In response to this:

[release-4.4] [release-4.5] Bug 1871832: initial create errors should map to SamplesExists instead of ImageChangesInProgress

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero gabemontero added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2020
@adambkaplan adambkaplan changed the title [release-4.4] [release-4.5] Bug 1871832: initial create errors should map to SamplesExists instead of ImageChangesInProgress [release-4.4] Bug 1871832: initial create errors should map to SamplesExists instead of ImageChangesInProgress Sep 10, 2020
adambkaplan
adambkaplan approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adambkaplan,gabemontero]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eparis
Copy link
Member

eparis commented Sep 10, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@eparis: This pull request references Bugzilla bug 1871832, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.4.z) matches configured target release for branch (4.4.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1857201 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1857201 targets the "4.5.z" release, which is one of the valid target releases: 4.5.0, 4.5.z
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eparis eparis added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 10, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@gabemontero
Copy link
Contributor Author

registry.redhat.io seems to be having an intermittent bout of unhappiness:

  Normal   Pulling    8m23s (x4 over 9m56s)   kubelet, ip-10-0-145-134.ec2.internal  Pulling image "image-registry.openshift-image-registry.svc:5000/openshift/mysql@sha256:62772b63c45a19a1559a8f13c103120f421a55d753a781dea1708f3053079457"
  Warning  Failed     8m22s (x4 over 9m55s)   kubelet, ip-10-0-145-134.ec2.internal  Failed to pull image "image-registry.openshift-image-registry.svc:5000/openshift/mysql@sha256:62772b63c45a19a1559a8f13c103120f421a55d753a781dea1708f3053079457": rpc error: code = Unknown desc = Error reading manifest sha256:62772b63c45a19a1559a8f13c103120f421a55d753a781dea1708f3053079457 in image-registry.openshift-image-registry.svc:5000/openshift/mysql: unknown: unable to pull manifest from registry.redhat.io/rhscl/mysql-80-rhel7@sha256:62772b63c45a19a1559a8f13c103120f421a55d753a781dea1708f3053079457: Get https://registry.redhat.io/v2/rhscl/mysql-80-rhel7/manifests/sha256:62772b63c45a19a1559a8f13c103120f421a55d753a781dea1708f3053079457: unauthorized: Please login to the Red Hat Registry using your Customer Portal credentials. Further instructions can be found here: https://access.redhat.com/RegistryAuthentication
  Warning  Failed     8m22s (x4 over 9m55s)   kubelet, ip-10-0-145-134.ec2.internal  Error: ErrImagePull

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 2f74320 into openshift:release-4.4 Sep 11, 2020
@openshift-ci-robot
Copy link
Contributor

@gabemontero: All pull requests linked via external trackers have merged:

Bugzilla bug 1871832 has been moved to the MODIFIED state.

In response to this:

[release-4.4] Bug 1871832: initial create errors should map to SamplesExists instead of ImageChangesInProgress

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero gabemontero deleted the openshift-cherrypick-robot-cherry-pick-304-to-release-4.4 branch September 11, 2020 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambkaplan adambkaplan adambkaplan approved these changes

@dmage dmage Awaiting requested review from dmage

Assignees

@adambkaplan adambkaplan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gabemontero @openshift-ci-robot @eparis @openshift-bot @adambkaplan @openshift-merge-robot