Bug 1902601: Fix resources in cinder csi deployment template #108
Conversation
|
/cc Fedosin |
There was a problem hiding this comment.
/lgtm
But we also have to do the same in the operator itself https://github.com/openshift/openstack-cinder-csi-driver-operator/blob/master/manifests/07_deployment.yaml
|
mandre
force-pushed
the
cinder-best-effort
branch
from
d6c121c
to
c67fbbb
Compare
| resources: | ||
| requests: | ||
| cpu: 10m | ||
| memory: 20Mi |
There was a problem hiding this comment.
Can you take the chance and use the same values used here?
mandre
force-pushed
the
cinder-best-effort
branch
from
c67fbbb
to
8b00078
Compare
Arg, this is not the first time. I should put this command in my git hooks. |
This should fix the "Managed cluster should ensure control plane pods do
not run in best-effort QoS" CI test that is currently failing with:
5 pods found in best-effort QoS:
openshift-cluster-csi-drivers/openstack-cinder-csi-driver-controller-5bfc8fdf46-k9h6f is running in best-effort QoS
openshift-cluster-csi-drivers/openstack-cinder-csi-driver-node-gqmzg is running in best-effort QoS
openshift-cluster-csi-drivers/openstack-cinder-csi-driver-node-hn5pp is running in best-effort QoS
openshift-cluster-csi-drivers/openstack-cinder-csi-driver-node-nsffx is running in best-effort QoS
openshift-cluster-csi-drivers/openstack-cinder-csi-driver-operator-7f968db7f-hkvmj is running in best-effort QoS
https://prow.ci.openshift.org/view/gcs/origin-ci-test/logs/release-openshift-ocp-installer-e2e-openstack-4.7/1334497702402068480
Also bump the memory requirements to 50Mi to align with aws-ebs.
mandre
force-pushed
the
cinder-best-effort
branch
from
8b00078
to
c2031b2
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, Fedosin, mandre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
mandre
changed the title
openshift-ci-robot
added
the
bugzilla/severity-high
|
@mandre: This pull request references Bugzilla bug 1902601, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
/bugzilla refresh |
|
@mandre: This pull request references Bugzilla bug 1902601, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
openshift-ci-robot
removed
the
bugzilla/invalid-bug
|
@mandre: All pull requests linked via external trackers have merged: Bugzilla bug 1902601 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This should fix the "Managed cluster should ensure control plane pods do
not run in best-effort QoS" CI test that is currently failing with:
https://prow.ci.openshift.org/view/gcs/origin-ci-test/logs/release-openshift-ocp-installer-e2e-openstack-4.7/1334497702402068480