Fix resources in deployment template #12
Conversation
manifests/07_deployment.yaml
Outdated
| resources: | ||
| requests: | ||
| cpu: 10m | ||
| memory: 20Mi |
There was a problem hiding this comment.
I think we need to fix the manifests in ./assets instead. Those are the resources that the operator deploys in the cluster.
There was a problem hiding this comment.
Suggestion: check the EBS operator here: https://github.com/openshift/aws-ebs-csi-driver-operator
There was a problem hiding this comment.
Thanks for the review @bertinatto.
I've fixed the manifests in openshift/cluster-storage-operator#108 and fixed them here too while I was at it.
I'm not sure I understand your comment about ./assets - could you clarify what needs to be fixed in the assets directory?
There was a problem hiding this comment.
Sorry, I meant to say we should also update the files in this directory:
https://github.com/openshift/openstack-cinder-csi-driver-operator/tree/master/assets
This will fix the QoS for the controller and the node shown in this message:
openshift/cluster-storage-operator#108 (comment)
We can keep the changes in this file (manifests/07_deployment.yaml), but you should also update the file in CSO (as you're correctly doing in PR https://github.com/openshift/cluster-storage-operator/pull/108/files). This particular file is here just for reference as it's not used by anything.
There was a problem hiding this comment.
Gotcha! I'll update accordingly.
|
@mandre: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Because of this error the containers were running in best-effort QoS. Also add resource constraints to the assets and align with aws-ebs's constraints values.
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, mandre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Because of this error the containers were running in best-effort QoS.