Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add YAMLs for starting vsphere-problem-detector as a deployment #110

Merged
merged 2 commits into from Dec 4, 2020
Merged

Add YAMLs for starting vsphere-problem-detector as a deployment #110

merged 2 commits into from Dec 4, 2020

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Dec 4, 2020

Deploy vsphere problem detector as a sidecar.

About metrics - I am wondering if same operator can have two endpoints that can be scraped by prometheus. Looking into existing operators that use ServiceMonitor , I don't find any example of this happening.

@gnufied gnufied changed the title Add code for starting vsphere-problem-detector WIP: Add code for starting vsphere-problem-detector Dec 4, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 4, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2020
@gnufied gnufied force-pushed the add-vsphere-problem-detector branch from f7a58d3 to f614171 Compare December 4, 2020 12:54
@gnufied gnufied changed the title WIP: Add code for starting vsphere-problem-detector Add YAMLs for starting vsphere-problem-detector as a deployment Dec 4, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 4, 2020
@jsafrane
Copy link
Contributor

jsafrane commented Dec 4, 2020 

Operator degraded (VSphereProblemDetectorController_SyncError): VSphereProblemDetectorControllerDegraded: unsupported platform: GCP | Operator degraded (VSphereProblemDetectorController_SyncError): VSphereProblemDetectorControllerDegraded: unsupported platform: GCP
-- | --
Operator degraded (VSphereProblemDetectorController_SyncError): VSphereProblemDetectorControllerDegraded: unsupported platform: GCP
 

Good news: it installs! Bad news: this must be merged first: openshift/vsphere-problem-detector#11

@gnufied
Copy link
Member Author

gnufied commented Dec 4, 2020

/retest

@jsafrane
Copy link
Contributor

jsafrane commented Dec 4, 2020 •
edited

/lgtm
AWS installation succeeded and vsphere-problem-detector pod container is there

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2020
@jsafrane
Copy link
Contributor

jsafrane commented Dec 4, 2020

/retest

5 similar comments
@jsafrane
Copy link
Contributor

jsafrane commented Dec 4, 2020

/retest

@jsafrane
Copy link
Contributor

jsafrane commented Dec 4, 2020

/retest

@gnufied
Copy link
Member Author

gnufied commented Dec 4, 2020

/retest

@jsafrane
Copy link
Contributor

jsafrane commented Dec 4, 2020

/retest

@gnufied
Copy link
Member Author

gnufied commented Dec 4, 2020

/retest

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2020
@jsafrane
Copy link
Contributor

jsafrane commented Dec 4, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bertinatto
Copy link
Member

/retest

@openshift-merge-robot openshift-merge-robot merged commit 3a7d2f5 into openshift:master Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane jsafrane left review comments

@bertinatto bertinatto Awaiting requested review from bertinatto

Assignees

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gnufied @jsafrane @openshift-ci-robot @bertinatto @openshift-merge-robot