Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: BUILD-256: add shared resource driver configuration configmap #234

Conversation

gabemontero
Copy link
Contributor

proved we could not use library-go static resource controller in shared resource operator;
it is truly "static" ... if we change the data field, the controller changes it back

but putting it in assets leverages the static resource controller as well in this repo (thanks for the reminder @coreydaley )

creating WIP PR with putting it in the CSO manifest, so the CVO creates it, similar to our other CVO based controllers

will launch cluster bot cluster to test if we can change

otherwise, we are back to the SRO either "manually" creating the configmap outside of library-go, or having to employ configobservers to deal with it

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 4, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 4, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gabemontero
To complete the pull request process, please assign jsafrane after the PR has been reviewed.
You can assign the PR to them by writing /assign @jsafrane in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 4, 2021

@gabemontero: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws 3becf8b link true /test e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gabemontero
Copy link
Contributor Author

/test e2e-aws-shared-resources

@gabemontero
Copy link
Contributor Author

yeah this didn't work ... not sure why @coreydaley

but a clusterbot cluster with this did not create the configmap

@gabemontero gabemontero closed this Nov 5, 2021
@gabemontero gabemontero deleted the sync-shared-resource-manifest branch November 5, 2021 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant