Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-13187: Make vsphere-problem-detector alerts configurable #380

Merged

Conversation

jsafrane
Copy link
Contributor

Create/delete detector's PrometheusRule instances based on value of ConfigMap vsphere-problem-detector.

Example:

apiVersion: v1
kind: ConfigMap
metadata:
  name: vsphere-problem-detector
  namespace: openshift-cluster-storage-operator
data:
  config.yaml: |
    alertsDisabled: true

cc @openshift/storage

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jun 19, 2023
@openshift-ci-robot
Copy link
Contributor

@jsafrane: This pull request references Jira Issue OCPBUGS-13187, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Create/delete detector's PrometheusRule instances based on value of ConfigMap vsphere-problem-detector.

Example:

apiVersion: v1
kind: ConfigMap
metadata:
 name: vsphere-problem-detector
 namespace: openshift-cluster-storage-operator
data:
 config.yaml: |
   alertsDisabled: true

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2023
@jsafrane jsafrane force-pushed the remove-detector-alerts branch 2 times, most recently from e8a0338 to ad7e8ec Compare June 20, 2023 10:20
Create/delete detector's PrometheusRule instances based on value of
ConfigMap `vsphere-problem-detector`.

Example:

```
apiVersion: v1
kind: ConfigMap
metadata:
  name: vsphere-problem-detector
  namespace: openshift-cluster-storage-operator
data:
  config.yaml: |
    alertsDisabled: true
```
@jsafrane
Copy link
Contributor Author

/retest

@gnufied
Copy link
Member

gnufied commented Jun 20, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 3198372 and 2 for PR HEAD 27d2598 in total

@jsafrane
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2023

@jsafrane: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit a3e819e into openshift:master Jun 21, 2023
14 checks passed
@openshift-ci-robot
Copy link
Contributor

@jsafrane: Jira Issue OCPBUGS-13187: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-13187 has not been moved to the MODIFIED state.

In response to this:

Create/delete detector's PrometheusRule instances based on value of ConfigMap vsphere-problem-detector.

Example:

apiVersion: v1
kind: ConfigMap
metadata:
 name: vsphere-problem-detector
 namespace: openshift-cluster-storage-operator
data:
 config.yaml: |
   alertsDisabled: true

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants