Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-13187: Revert "Allow disabling the operator via ConfigMap" #122

Merged
merged 1 commit into from Jun 21, 2023
Merged

OCPBUGS-13187: Revert "Allow disabling the operator via ConfigMap" #122

merged 1 commit into from Jun 21, 2023

Conversation

jsafrane
Copy link
Contributor

This reverts commit f18e269.

We will disable vpshere-problem-detector alerts in CSO, by deleting PrometheusRules.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jun 19, 2023
@openshift-ci-robot
Copy link
Contributor

@jsafrane: This pull request references Jira Issue OCPBUGS-13187, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This reverts commit f18e269.

We will disable vpshere-problem-detector alerts in CSO, by deleting PrometheusRules.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from gnufied and tsmetana June 19, 2023 14:56
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2023
@jsafrane
Revert "Allow disabling the operator via ConfigMap"
96e156c 
This reverts commit f18e269.

We will disable vpshere-problem-detector alerts in CSO, by deleting
PrometheusRules.
@jsafrane
Copy link
Contributor Author

/retest

@gnufied
Copy link
Member

gnufied commented Jun 20, 2023

So basically after this revert there is no way to disable the vsphere-problem-detector and a user can only disable the alert.

@gnufied
Copy link
Member

gnufied commented Jun 20, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 11a539a and 2 for PR HEAD 96e156c in total

@jsafrane
Copy link
Contributor Author

/retest

@openshift-ci-robot openshift-ci-robot mentioned this pull request Jun 21, 2023
Merged
@jsafrane
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2023

@jsafrane: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit ca0c58e into openshift:master Jun 21, 2023
8 checks passed
@openshift-ci-robot
Copy link
Contributor

@jsafrane: Jira Issue OCPBUGS-13187: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-13187 has been moved to the MODIFIED state.

In response to this:

This reverts commit f18e269.

We will disable vpshere-problem-detector alerts in CSO, by deleting PrometheusRules.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufied gnufied Awaiting requested review from gnufied

@tsmetana tsmetana Awaiting requested review from tsmetana

Assignees

@gnufied gnufied

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jsafrane @openshift-ci-robot @gnufied @openshift-merge-robot