Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1866262: Remove DriverConfig from CSI operator CRs #76

Merged

Conversation

jsafrane
Copy link
Contributor

We do not have use for the field, so remove it. Bump openshift/api to get the updated type.

We removed it from ClusterCSIDriver CRD as it does not have any use now.
To get updated ClusterCSIDriver
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Aug 18, 2020
@openshift-ci-robot
Copy link
Contributor

@jsafrane: This pull request references Bugzilla bug 1866262, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1866262: Remove DriverConfig from CSI operator CRs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 18, 2020
@jsafrane
Copy link
Contributor Author

/test e2e-openstack
/test e2e-ovirt

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2020
@jsafrane
Copy link
Contributor Author

cc @openshift/storage

@jsafrane
Copy link
Contributor Author

/test e2e-openstack

@bertinatto
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [bertinatto,jsafrane]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bertinatto
Copy link
Member

/test e2e-aws

@openshift-merge-robot openshift-merge-robot merged commit ae44d6e into openshift:master Aug 18, 2020
@openshift-ci-robot
Copy link
Contributor

@jsafrane: All pull requests linked via external trackers have merged: openshift/cluster-storage-operator#76. Bugzilla bug 1866262 has been moved to the MODIFIED state.

In response to this:

Bug 1866262: Remove DriverConfig from CSI operator CRs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bertinatto
Copy link
Member

Will you update the manifests from CSI operators repos as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants