Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.7] Pack both keys in one verifier-public-key-ci entry #36

Merged
merged 1 commit into from May 18, 2021
Merged

[release-4.7] Pack both keys in one verifier-public-key-ci entry #36

merged 1 commit into from May 18, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #35

/assign vrutkovs

@vrutkovs
Pack both keys in one verifier-public-key-ci entry
5b78d89 
Two configmap keys means "must be signed by both keys". What we want instead is "signed by either key".
In order to archive that both keys need to be dearmored, concatenated and armored back.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 11, 2021
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 11, 2021

@openshift-cherrypick-robot: GitHub didn't allow me to assign the following users: vrutkovs.

Note that only openshift members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

This is an automated cherry-pick of #35

/assign vrutkovs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs vrutkovs mentioned this pull request May 15, 2021
Closed
@smarterclayton
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 18, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2021
@smarterclayton smarterclayton added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels May 18, 2021
@smarterclayton
Copy link
Contributor

Does not impact OCP

@openshift-merge-robot openshift-merge-robot merged commit b7e7917 into openshift:release-4.7 May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crawford crawford Awaiting requested review from crawford

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@smarterclayton smarterclayton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@openshift-cherrypick-robot @smarterclayton @openshift-merge-robot @vrutkovs