metrics: Report a gauge for when cluster operator conditions change #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
approved
|
/retest |
|
/retest |
|
/assign @abhinavdahiya |
Cluster operators may "flap" - have conditions that periodically move from true to false (or appear and disappear). The CVO can record all transitions as they occur and report it to prometheus, allowing us to get fine grained reports of transitions. Since most operators should be stable, treat Unknown -> False and <missing> -> Unknown as just as valid, on the assumption that transitions are important. Will allow us to identify flapping operators and fix them.
smarterclayton
force-pushed
the
transition_metrics
branch
from
af8851a
to
648d27c
Compare
|
Resolved, also cleaned up the naming to be slightly more concise. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cluster operators may "flap" - have conditions that periodically
move from true to false (or appear and disappear). The CVO can record
all transitions as they occur and report it to prometheus, allowing
us to get fine grained reports of transitions. Since most operators
should be stable, treat Unknown -> False and -> Unknown
as just as valid, on the assumption that transitions are important.
Will allow us to identify flapping operators and fix them.