Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install: add service monitor manifest #214

Merged
merged 1 commit into from Jul 5, 2019

Conversation

paulfantom
Copy link
Contributor

Since each team should own their monitoring configuration we are removing ServiceMonitor manifests from cluster-monitoring-operator.

Related to openshift/cluster-monitoring-operator#390

/cc @brancz @smarterclayton

@openshift-ci-robot
Copy link
Contributor

@paulfantom: GitHub didn't allow me to request PR reviews from the following users: brancz.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Since each team should own their monitoring configuration we are removing ServiceMonitor manifests from cluster-monitoring-operator.

Related to openshift/cluster-monitoring-operator#390

/cc @brancz @smarterclayton

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 27, 2019
@brancz
Copy link
Contributor

brancz commented Jun 27, 2019

/lgtm

@openshift-ci-robot
Copy link
Contributor

@brancz: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhinavdahiya
Copy link
Contributor

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2019
@brancz
Copy link
Contributor

brancz commented Jul 3, 2019

@abhinavdahiya could you also /lgtm this? It seems that I don't have permission to do so.

@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, brancz, paulfantom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit d446774 into openshift:master Jul 5, 2019
@paulfantom paulfantom deleted the servicemonitor branch July 11, 2019 07:49
abhinavdahiya added a commit to abhinavdahiya/cluster-version-operator that referenced this pull request Jul 11, 2019
the `manifests` directory on the bootstrap is used by the cluster-bootstrap to push to the cluster.
`servicemonitor` for cvo was added by openshift#214
`servicemonitor` api is created by the cluster-monitoring-operator and therefore this causes the bootstrapping to get stuck until we get the monitoring operator running.

This skips the `servicemonitor` in the bootstrap render as it is not required for the bootstrap cvo pod.
abhinavdahiya added a commit to abhinavdahiya/cluster-version-operator that referenced this pull request Aug 26, 2019
the `manifests` directory on the bootstrap is used by the cluster-bootstrap to push to the cluster.
`servicemonitor` for cvo was added by openshift#214
`servicemonitor` api is created by the cluster-monitoring-operator and therefore this causes the bootstrapping to get stuck until we get the monitoring operator running.

This skips the `servicemonitor` in the bootstrap render as it is not required for the bootstrap cvo pod.
wking pushed a commit to wking/cluster-version-operator that referenced this pull request Oct 17, 2019
the `manifests` directory on the bootstrap is used by the cluster-bootstrap to push to the cluster.
`servicemonitor` for cvo was added by openshift#214
`servicemonitor` api is created by the cluster-monitoring-operator and therefore this causes the bootstrapping to get stuck until we get the monitoring operator running.

This skips the `servicemonitor` in the bootstrap render as it is not required for the bootstrap cvo pod.
abhinavdahiya added a commit to abhinavdahiya/cluster-version-operator that referenced this pull request Oct 22, 2019
the `manifests` directory on the bootstrap is used by the cluster-bootstrap to push to the cluster.
`servicemonitor` for cvo was added by openshift#214
`servicemonitor` api is created by the cluster-monitoring-operator and therefore this causes the bootstrapping to get stuck until we get the monitoring operator running.

This skips the `servicemonitor` in the bootstrap render as it is not required for the bootstrap cvo pod.
abhinavdahiya added a commit to abhinavdahiya/cluster-version-operator that referenced this pull request Oct 22, 2019
the `manifests` directory on the bootstrap is used by the cluster-bootstrap to push to the cluster.
`servicemonitor` for cvo was added by openshift#214
`servicemonitor` api is created by the cluster-monitoring-operator and therefore this causes the bootstrapping to get stuck until we get the monitoring operator running.

This skips the `servicemonitor` in the bootstrap render as it is not required for the bootstrap cvo pod.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants