Bug 1795412: Print whether CRDs are updated #258
Conversation
openshift-ci-robot
added
the
size/L
|
/assign @abhinavdahiya @smarterclayton |
|
Since clients of the Apply are using updated only to print it, I would prefer that updated remain internal to Apply.. so maybe printing in apply itself. |
openshift-ci-robot
added
size/XS
sttts
changed the title
sttts
changed the title
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@sttts: This pull request references Bugzilla bug 1795412, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@abhinavdahiya added the logging to the apply func, simple twoliner. PTAL. This will help us to diagnose https://bugzilla.redhat.com/show_bug.cgi?id=1795412. Continuous CRD updates increase CPU usage of the apiservers. |
|
/lgtm |
sdodson
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@sttts: All pull requests linked via external trackers have merged. Bugzilla bug 1795412 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This will help to see hotloops due to missing defaults in manifests, leading invisibly to https://bugzilla.redhat.com/show_bug.cgi?id=1795412.