Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1793209: Don't use protobuf client for SecurityContextConstraints #308

Merged
merged 1 commit into from Jan 22, 2020

Conversation

tkashem
Copy link
Contributor

@tkashem tkashem commented Jan 21, 2020

Kubernetes apiservers began enforcing selection of protobuf for resources that support it, whereas before they silently ignored it. CRDs don't support protobuf.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 21, 2020
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 21, 2020
@tkashem
Copy link
Contributor Author

tkashem commented Jan 21, 2020

/retest

@tkashem tkashem changed the title [WIP] Don't use protobuf client for SecurityContextConstraints [WIP] Bug 1793209: Don't use protobuf client for SecurityContextConstraints Jan 21, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 21, 2020
@openshift-ci-robot
Copy link
Contributor

@tkashem: This pull request references Bugzilla bug 1793209, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

[WIP] Bug 1793209: Don't use protobuf client for SecurityContextConstraints

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tkashem
Copy link
Contributor Author

tkashem commented Jan 21, 2020

/retest

@tkashem tkashem changed the title [WIP] Bug 1793209: Don't use protobuf client for SecurityContextConstraints Bug 1793209: Don't use protobuf client for SecurityContextConstraints Jan 21, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 21, 2020
@sttts
Copy link
Contributor

sttts commented Jan 22, 2020

/lgtm
/approve

@openshift-ci-robot
Copy link
Contributor

@sttts: changing LGTM is restricted to collaborators

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Jan 22, 2020

/uncc @abhinavdahiya
/cc @wking @smarterclayton
PTAL

@openshift-ci-robot openshift-ci-robot requested review from smarterclayton and removed request for abhinavdahiya January 22, 2020 13:57
@mfojtik
Copy link
Member

mfojtik commented Jan 22, 2020

/lgtm

SCC are CR resources, protobuf does not work for those, this is critical fix.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2020
@sdodson sdodson added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 22, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: mfojtik, sttts, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdodson
Copy link
Member

sdodson commented Jan 22, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@sdodson: This pull request references Bugzilla bug 1793209, which is valid.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 22, 2020
@openshift-merge-robot openshift-merge-robot merged commit 9281b45 into openshift:master Jan 22, 2020
@openshift-ci-robot
Copy link
Contributor

@tkashem: All pull requests linked via external trackers have merged. Bugzilla bug 1793209 has been moved to the MODIFIED state.

In response to this:

Bug 1793209: Don't use protobuf client for SecurityContextConstraints

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@tkashem: Bugzilla bug 1793209 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

In response to this:

Bug 1793209: Don't use protobuf client for SecurityContextConstraints

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tkashem
Copy link
Contributor Author

tkashem commented Jan 23, 2020

/cherry-pick release-4.3

@openshift-cherrypick-robot

@tkashem: new pull request created: #310

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants