Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1782982: pkg/verify/verifyconfigmap: Add klog logging #332

Merged
merged 1 commit into from Feb 28, 2020
Merged

Bug 1782982: pkg/verify/verifyconfigmap: Add klog logging #332

merged 1 commit into from Feb 28, 2020

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #328

/assign sdodson

@wking
pkg/verify/verifyconfigmap: Add klog logging
0d92dcb 
To make it easier to understand where things are breaking down when
they don't work as expected [1].

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1782982#c16
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 26, 2020
Merged
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 26, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1805172, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "4.5.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead
  • expected Bugzilla bug 1805172 to depend on a bug in one of the following states: MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.4] Bug 1805172: pkg/verify/verifyconfigmap: Add klog logging

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 26, 2020
@sdodson
Copy link
Member

sdodson commented Feb 26, 2020

/assign @jottofar

@sdodson
Copy link
Member

sdodson commented Feb 26, 2020

/retitle Bug 1782982: pkg/verify/verifyconfigmap: Add klog logging

@openshift-ci-robot openshift-ci-robot changed the title [release-4.4] Bug 1805172: pkg/verify/verifyconfigmap: Add klog logging Bug 1782982: pkg/verify/verifyconfigmap: Add klog logging Feb 26, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 26, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1782982, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1782982: pkg/verify/verifyconfigmap: Add klog logging

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Feb 26, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 26, 2020
@sdodson
Copy link
Member

sdodson commented Feb 26, 2020

/hold
This comment leads me to believe that additional fixes are still necessary beyond just this logging change, so we should probably get everything sorted on master before we complete the backport?

https://bugzilla.redhat.com/show_bug.cgi?id=1782982#c19

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2020
@jottofar
Copy link
Contributor

/cc @sdodson hold is fine since #328 is just logging to help identify the issue. Once we find the issue I can backport all that's needed.

@openshift-bot
Copy link
Contributor

/bugzilla refresh

The requirements for Bugzilla bugs have changed, recalculating validity.

@openshift-ci-robot
Copy link
Contributor

@openshift-bot: This pull request references Bugzilla bug 1782982, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.4.0) matches configured target release for branch (4.4.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1805172 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1805172 targets the "4.5.0" release, matching the expected (4.5.0) release
  • bug has dependents

In response to this:

/bugzilla refresh

The requirements for Bugzilla bugs have changed, recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Feb 27, 2020

/lgtm
/approve
/retest

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdodson
Copy link
Member

sdodson commented Feb 27, 2020

/hold cancel
We'll pull this into 4.4 so that we have parity with master branch and to improve any future debugging of customer reported issues.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2020
@sdodson
Copy link
Member

sdodson commented Feb 27, 2020

/test ci/prow/integration
What is this test? It has no history

@jottofar
Copy link
Contributor

/test e2e-aws-upgrade

@sdodson
Copy link
Member

sdodson commented Feb 27, 2020

/override ci/prow/integration

@openshift-ci-robot
Copy link
Contributor

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/integration

In response to this:

/override ci/prow/integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Feb 27, 2020

/refresh

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sdodson
Copy link
Member

sdodson commented Feb 27, 2020

/override ci/prow/e2e-aws-upgrade
Those are known issues with service and api availability during upgrades. No other failures.

@openshift-ci-robot
Copy link
Contributor

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-aws-upgrade

In response to this:

/override ci/prow/e2e-aws-upgrade
Those are known issues with service and api availability during upgrades. No other failures.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Feb 27, 2020

/override ci/prow/e2e-aws-upgrade

@openshift-ci-robot
Copy link
Contributor

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-aws-upgrade

In response to this:

/override ci/prow/e2e-aws-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Feb 27, 2020

/refresh

@sdodson sdodson closed this Feb 27, 2020
@sdodson sdodson reopened this Feb 27, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1782982, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.4.0) matches configured target release for branch (4.4.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1805172 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1805172 targets the "4.5.0" release, matching the expected (4.5.0) release
  • bug has dependents

In response to this:

Bug 1782982: pkg/verify/verifyconfigmap: Add klog logging

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jottofar
Copy link
Contributor

/test e2e-aws-upgrade

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sdodson
Copy link
Member

sdodson commented Feb 28, 2020

/override ci/prow/integration

@openshift-ci-robot
Copy link
Contributor

@sdodson: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • ci/prow/integration

Only the following contexts were expected:

  • ci/prow/e2e-aws
  • ci/prow/e2e-aws-upgrade
  • ci/prow/e2e-aws-upi
  • ci/prow/images
  • ci/prow/integration
  • ci/prow/unit
  • tide

In response to this:

/override ci/prow/integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Feb 28, 2020

Need to figure out why the results from this job aren't being posted properly.

@sdodson
Copy link
Member

sdodson commented Feb 28, 2020

/skip

@stevekuznetsov
Copy link

/test integration

@openshift-merge-robot openshift-merge-robot merged commit 2385690 into openshift:release-4.4 Feb 28, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1782982 has been moved to the MODIFIED state.

In response to this:

Bug 1782982: pkg/verify/verifyconfigmap: Add klog logging

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking mentioned this pull request Jul 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdodson sdodson Awaiting requested review from sdodson

@wking wking Awaiting requested review from wking

Assignees

@sdodson sdodson

@jottofar jottofar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@openshift-cherrypick-robot @openshift-ci-robot @sdodson @jottofar @openshift-bot @stevekuznetsov @openshift-merge-robot @wking