Bug 1805172: pkg/verify/verifyconfigmap: Add klog logging #328
Conversation
To make it easier to understand where things are breaking down when they don't work as expected [1]. [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1782982#c16
openshift-ci-robot
added
bugzilla/valid-bug
|
@wking: This pull request references Bugzilla bug 1805172, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
size/S
More on that in rhbz#1801885 and rhbz#1802246. /retest |
|
Not much in the CI logs, but we'd need a rollback test (which we don't have at the moment) to really excercise the verify code. Presence of throttling there suggests that maybe some of my new logs are not firing. Not sure why they wouldn't, we do have |
|
/cc @jottofar @vrutkovs PTAL |
openshift-ci-robot
requested review from
vrutkovs
and removed request for
smarterclayton
|
@sdodson: GitHub didn't allow me to request PR reviews from the following users: jottofar, PTAL. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@sdodson: GitHub didn't allow me to request PR reviews from the following users: jottofar. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| for k, v := range cm.BinaryData { | ||
| if strings.HasPrefix(k, prefix) { | ||
| klog.V(4).Infof("key %s from signature config map %s matches %s", k, cm.ObjectMeta.Name, digest) |
There was a problem hiding this comment.
Log prefix here in case it gets incorrectly generated? A better idea would be logging result in digestToKeyPrefix too
There was a problem hiding this comment.
Shouldn't get here if the digest string had incorrect format. Logging prefix is just for info.
There was a problem hiding this comment.
I'm already logging the prefix a few lines up with searching for {prefix} in signature config map...?
|
/cc @jottofar |
|
/test e2e-aws-upgrade |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jottofar, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@wking: All pull requests linked via external trackers have merged. Bugzilla bug 1805172 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.4 |
|
@sdodson: new pull request created: #332 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
To make it easier to understand where things are breaking down when they don't work as expected.