Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document steps to build and run CVO locally #381

Merged

Conversation

jottofar
Copy link
Contributor

@jottofar jottofar commented Jun 8, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2020
@jottofar jottofar force-pushed the ota-225-run-cvo-locally branch 4 times, most recently from 0b741c9 to e6ad29e Compare June 8, 2020 16:40
@jottofar
Copy link
Contributor Author

jottofar commented Jun 8, 2020

/assign @LalatenduMohanty

docs/dev/run-cvo-locally.md Outdated Show resolved Hide resolved
docs/dev/run-cvo-locally.md Outdated Show resolved Hide resolved
docs/dev/run-cvo-locally.md Outdated Show resolved Hide resolved
@jottofar jottofar force-pushed the ota-225-run-cvo-locally branch 2 times, most recently from b725224 to c7cdbc3 Compare June 8, 2020 18:02
docs/dev/run-cvo-locally.md Outdated Show resolved Hide resolved
Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

20e42a3 looks good to me. I'll drop a hold too so @LalatenduMohanty and others can comment, but if nobody raises concerns or pulls the hold before then, I'll pull it myself tomorrow.

/lgtm
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 8, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2020
docs/dev/run-cvo-locally.md Outdated Show resolved Hide resolved
docs/dev/run-cvo-locally.md Outdated Show resolved Hide resolved
docs/dev/run-cvo-locally.md Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2020
docs/dev/run-cvo-locally.md Outdated Show resolved Hide resolved
Document instructions to build and run the CVO executable locally,for
example on your development laptop, allowing a "quick-turn" test
capability.
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jottofar, LalatenduMohanty, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [LalatenduMohanty,jottofar,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LalatenduMohanty
Copy link
Member

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 10, 2020
@openshift-merge-robot openshift-merge-robot merged commit febb0aa into openshift:master Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants