CONTRIBUTING: Add a contributing file #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated with: $ go fmt ./... using: $ go version go version go1.13.5 linux/amd64
openshift-ci-robot
added
the
approved
wking
force-pushed
the
contributing-docs
branch
2 times, most recently
from
2e183d1
to
aff7628
Compare
jottofar
reviewed
Jun 17, 2020
Based on [1], but with a few local changes like: * No section about mock tests, because we don't have any. * No section about the Developer Certificate of Origin, because we don't use Signed-off-by, and I'm skeptical about how binding a CONTRIBUTING.md -> DCO link is vs. a contributor claiming "I just wrote a commit; I didn't read all the docs in the repo first". If we decide that a CONTRIBUTING.md -> DCO link is binding, we can always add it later. * Trimmed down section about linting, because we don't do as much of that as the installer. * One sentence per line, so we don't have to worry about rewrapping (and complicating diff/blame) as we edit this content going forward. * Whatever else seemed reasonable when I went through ;). [1]: https://github.com/openshift/installer/blob/4e46d0a347533263903beb3349a33f53eee7a6c2/CONTRIBUTING.md
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jottofar, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the installer's, but with a few local changes like:
Signed-off-by, and I'm skeptical about how binding aCONTRIBUTING.md->DCOlink is vs. a contributor claiming "I just wrote a commit; I didn't read all the docs in the repo first". If we decide that aCONTRIBUTING.md->DCOlink is binding, we can always add it later.Also wash the repository through
go fmt ./....