Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1848729: Expand supported set of probe field mutations #389

Merged
merged 1 commit into from
Jun 19, 2020
Merged

Bug 1848729: Expand supported set of probe field mutations #389

merged 1 commit into from
Jun 19, 2020

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #383

/assign wking

@ironcladlou
Expand supported set of probe field mutations
202578a 
Before this change, only the initialDelaySeconds field of probes could be
updated. This patch expands the set of supported fields to include all the
other int32 fields of probes so that CVO will roll out such changes.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 18, 2020
Merged
@wking wking changed the title [release-4.5] Bug 1847672: Expand supported set of probe field mutations Bug 1847672: Expand supported set of probe field mutations Jun 18, 2020
@wking
Copy link
Member

wking commented Jun 18, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Bugzilla bug 1847672 has been cloned as Bugzilla bug 1848729. Retitling PR to link against new bug.
/retitle [release-4.5] Bug 1848729: Expand supported set of probe field mutations

In response to this:

[release-4.5] Bug 1847672: Expand supported set of probe field mutations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title Bug 1847672: Expand supported set of probe field mutations [release-4.5] Bug 1848729: Expand supported set of probe field mutations Jun 18, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jun 18, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1848729, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1847672 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 1847672 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

[release-4.5] Bug 1848729: Expand supported set of probe field mutations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 18, 2020
@wking
Copy link
Member

wking commented Jun 18, 2020

/assign @sdodson

For group-lead approval. See this test showing that the new code works in 4.6.

@sdodson sdodson added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Jun 19, 2020
@openshift-merge-robot openshift-merge-robot merged commit 40ec7e4 into openshift:release-4.5 Jun 19, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: openshift/cluster-version-operator#389. Bugzilla bug 1848729 has been moved to the MODIFIED state.

In response to this:

[release-4.5] Bug 1848729: Expand supported set of probe field mutations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member

wking commented Jun 19, 2020

/cherrypick release-4.4

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 19, 2020
Merged
@openshift-cherrypick-robot
Copy link
Author

@wking: new pull request created: #390

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking changed the title [release-4.5] Bug 1848729: Expand supported set of probe field mutations Bug 1848729: Expand supported set of probe field mutations Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LalatenduMohanty LalatenduMohanty Awaiting requested review from LalatenduMohanty

@vrutkovs vrutkovs Awaiting requested review from vrutkovs

Assignees

@sdodson sdodson

@wking wking

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@openshift-cherrypick-robot @wking @openshift-ci-robot @sdodson @openshift-merge-robot @ironcladlou