Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1862524: pkg/cvo/status: Raise Operator leveling grace-period to 20 minutes #422

Conversation

wking
Copy link
Member

@wking wking commented Jul 31, 2020

Reduce false-positives when operators take a while to level (like the machine-config operator, which has to roll the control plane machines). We may want to raise this further in the future, but baby steps ;).

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2020
Reduce false-positives when operators take a while to level (like the
machine-config operator, which has to roll the control plane
machines).  We may want to raise this further in the future, but baby
steps ;).

The previous 10-minute value is from c2ac20f (status: Report the
operators that have not yet deployed, 2019-04-09, openshift#158), which doesn't
make a case for that specific value.  So the bump is unlikely to break
anything unexpected.
@sdodson
Copy link
Member

sdodson commented Jul 31, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2020
@wking wking force-pushed the raise-operator-leveling-timeout branch from b3af092 to 08d5c42 Compare July 31, 2020 15:53
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2020
@sdodson
Copy link
Member

sdodson commented Jul 31, 2020

/retitle Bug 1862524: pkg/cvo/status: Raise Operator leveling grace-period to 20 minutes

@openshift-ci-robot openshift-ci-robot changed the title pkg/cvo/status: Raise Operator leveling grace-period to 20 minutes Bug 1862524: pkg/cvo/status: Raise Operator leveling grace-period to 20 minutes Jul 31, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Jul 31, 2020
@openshift-ci-robot
Copy link
Contributor

@wking: This pull request references Bugzilla bug 1862524, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1862524: pkg/cvo/status: Raise Operator leveling grace-period to 20 minutes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 31, 2020
@sdodson
Copy link
Member

sdodson commented Jul 31, 2020

/refresh

@wking
Copy link
Member Author

wking commented Jul 31, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot removed the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Jul 31, 2020
@openshift-ci-robot
Copy link
Contributor

@wking: This pull request references Bugzilla bug 1862524, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jul 31, 2020
@sdodson
Copy link
Member

sdodson commented Jul 31, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdodson
Copy link
Member

sdodson commented Jul 31, 2020

/hold
We'll wait in the queue behind other 4.6 feature work since CI is slammed right now.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2020
@sdodson
Copy link
Member

sdodson commented Aug 1, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 1, 2020
@openshift-merge-robot openshift-merge-robot merged commit ed864d6 into openshift:master Aug 1, 2020
@openshift-ci-robot
Copy link
Contributor

@wking: All pull requests linked via external trackers have merged: openshift/cluster-version-operator#422. Bugzilla bug 1862524 has been moved to the MODIFIED state.

In response to this:

Bug 1862524: pkg/cvo/status: Raise Operator leveling grace-period to 20 minutes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the raise-operator-leveling-timeout branch August 1, 2020 19:39
@sdodson
Copy link
Member

sdodson commented Aug 3, 2020

/cherrypick release-4.5

@openshift-cherrypick-robot

@sdodson: #422 failed to apply on top of branch "release-4.5":

In response to this:

/cherrypick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member Author

wking commented Aug 5, 2020

Manually backported in #427.

sdodson added a commit to sdodson/cluster-version-operator that referenced this pull request Oct 1, 2020
Similar to openshift#422, further tune things up so that we can ensure that
our 90th percentile of clusters do not trip over momentary cluster
upgrade failures whenever operators take longer than 20 minutes to
roll out.
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/cluster-version-operator that referenced this pull request Oct 2, 2020
Similar to openshift#422, further tune things up so that we can ensure that
our 90th percentile of clusters do not trip over momentary cluster
upgrade failures whenever operators take longer than 20 minutes to
roll out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants